-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2.0 Berlin #1090
Release v0.2.0 Berlin #1090
Changes from 4 commits
16a3007
987b198
3c50bc6
0c09c78
f0eb00d
bd90670
b12fb05
ecf82c1
9d33ffb
01dbd05
16da3c8
a3be38e
ff151c8
1f9b700
042fc8b
20e5972
9db69a3
6a97585
946f727
ee221a6
3f3f6b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "solang" | ||
version = "0.1.13" | ||
version = "0.2.0" | ||
authors = ["Sean Young <[email protected]>"] | ||
homepage = "https://github.com/hyperledger/solang" | ||
documentation = "https://solang.readthedocs.io/" | ||
|
@@ -46,7 +46,7 @@ itertools = "0.10" | |
num-rational = "0.4" | ||
indexmap = "1.8" | ||
once_cell = "1.10" | ||
solang-parser = { path = "solang-parser", version = "0.1.18" } | ||
solang-parser = { path = "solang-parser", version = "0.2.0" } | ||
codespan-reporting = "0.11" | ||
phf = { version = "0.11", features = ["macros"] } | ||
rust-lapper = "1.0" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,17 +116,6 @@ node flipper.js | |
|
||
## Build for Substrate | ||
|
||
### Status | ||
:warning: Solang was developed against Substrate v3.0. It has been a while since the last time the Substrate target was worked on, which introduced a few known regressions. Currently, the following is known to **not** work with recent Substrate versions: | ||
|
||
* Function call arguments of type `address` | ||
* Function return values of type `address` | ||
* Cross-contract calls | ||
* Events with indexed fields | ||
|
||
Maintenance on the Substrate target has now resumed and we are working on fixing these issues. | ||
|
||
### Building | ||
Run: | ||
|
||
```bash | ||
|
@@ -156,8 +145,8 @@ Here is a brief description of what we envision for the next versions. | |
| Solana SPL tokens compatibility | Completed | | ||
| Parse and resolve inline assembly | Completed | | ||
| Generate code for inline assembly | Completed | | ||
| Support Solana's Program Derived Addresses | In Progress | | ||
| Support latest Substrate production target | In Progress | | ||
| Support Solana's Program Derived Addresses | Completed | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is my Anchor PR #1034 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #1034 should get merged in the next few days? It would be really nice to have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think the release needs to wait for this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I put this back to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm what do you think of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did put it under |
||
| Support latest Substrate production target | Completed | | ||
|
||
|
||
### V0.3 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "solang-parser" | ||
version = "0.1.18" | ||
version = "0.2.0" | ||
authors = ["Sean Young <[email protected]>"] | ||
homepage = "https://github.com/hyperledger/solang" | ||
documentation = "https://solang.readthedocs.io/" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are built during release, so usually we update these after release (not ideal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this work if first tag it and let the release job run? Since this is in the
test.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release job is run in parallel to the test job, so it will work if we re-run it after the release job.
I don't know a way of making the test workflow depend on the release workflow, conditionally if there is a release workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on todays standup, to achieve this the first step would be to split our CI workflows to separate
build
fromtest
jobs, so that early stagebuild
artifacts can be used for tests but also as release assets. A further improvement would be to use something like bazel to gain the ability to "run" the CI locally.But how should we proceed here, should we try it like this (with the re run) or should I undo these changes for a follow up (having it included here would be nicer IMO)?