-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #0000: On-chain predictable iteration order #4130
[fix] #0000: On-chain predictable iteration order #4130
Conversation
c45cccc
to
2ab42c7
Compare
Pull Request Test Coverage Report for Build 7179205152
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the issue you wrote that you'll use BTree*
collections. Why did you change your mind?
36fe1f3
to
65146ae
Compare
fca8b85
to
42a889b
Compare
it seemed as a more natural replacement. As long as the bug is fixed we can always switch to b-trees. |
5b76dbb
to
54d09db
Compare
54d09db
to
2ba6ace
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So index at the end
2ba6ace
to
e7a3617
Compare
Signed-off-by: Marin Veršić <[email protected]>
e7a3617
to
2d57d6c
Compare
…4130) Signed-off-by: Marin Veršić <[email protected]>
…4130) Signed-off-by: Marin Veršić <[email protected]> Signed-off-by: Asem-Abdelhady <[email protected]>
…4130) Signed-off-by: Marin Veršić <[email protected]>
Description
HashMap
/HashSet
iniroha_core
withIndexMap
/IndexSet
HashMap
/HashSet
todissallowed_types
Linked issue
Closes #3
Benefits
Checklist
CONTRIBUTING.md