test(connector-fabric): fix module requires Go 1.17 #914

petermetz · 2021-05-04T16:40:33Z

Describe the bug

The hello world contract we deploy for the 1.4.x tests via go sources does not have it's dependencies pinned in the tests so the auto-upgrade finally broke the test:

'go: finding golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> '# golang.org/x/net/http2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> '../../pkg/mod/golang.org/x/[email protected]/http2/transport.go:598:14: undefined: tls.Dialer\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> 'note: module requires Go 1.17',

To Reproduce

Run the tests.

Expected behavior

Tests pass.

Logs/Stack traces

om:7051 --env CORE_PEER_MSPCONFIGPATH=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/peerOrganizations/org1.example.com/users/[email protected]/msp --env CORE_PEER_TLS_ROOTCERT_FILE=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/peerOrganizations/org1.example.com/peers/peer0.org1.example.com/tls/ca.crt --env ORDERER_TLS_ROOTCERT_FILE=/opt/gopath/src/github.com/hyperledger/fabric/peer/crypto/ordererOrganizations/example.com/orderers/orderer.example.com/msp/tlscacerts/tlsca.example.com-cert.pem --env GO111MODULE=on --workdir=/opt/gopath/src/hello-world cli  go build
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1> [2021-05-04T16:24:20.590Z] DEBUG (PluginLedgerConnectorFabric): go build CMD Response: {
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   code: 2,
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   signal: null,
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   stdout: 'debug1: permanently_set_uid: 0/0\r\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'Environment:\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  USER=root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  LOGNAME=root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  HOME=/root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  PATH=/bin:/usr/bin:/sbin:/usr/sbin\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  MAIL=/var/mail/root\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SHELL=/bin/ash\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  TERM=vt100\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_CLIENT=172.17.0.1 57648 22\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_CONNECTION=172.17.0.1 57648 172.17.0.2 22\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '  SSH_TTY=/dev/pts/1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding google.golang.org/protobuf v1.26.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/fsnotify/fsnotify v1.4.9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/hashicorp/hcl v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/magiconair/properties v1.8.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/pelletier/go-toml v1.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/jwalterweatherman v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/cast v1.3.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/afero v1.1.2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/subosito/gotenv v1.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding go.uber.org/atomic v1.6.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding go.uber.org/multierr v1.5.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding gopkg.in/ini.v1 v1.51.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/spf13/pflag v1.0.3\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/sys v0.0.0-20210423082822-04245dca01da\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/docker v20.10.3-0.20210216175712-646072ed6524+incompatible\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/text v0.3.6\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/go-units v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/image-spec v1.0.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/containerd/containerd v1.4.3\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/docker/go-connections v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/sirupsen/logrus v1.7.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/sys/mount v0.2.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/containerd/continuity v0.0.0-20210208174643-50096c924a4e\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/morikuni/aec v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/term v0.0.0-20201216013528-df9cb8a40635\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/runc v0.1.1\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/gogo/protobuf v1.3.2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/opencontainers/go-digest v1.0.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding github.com/moby/sys/mountinfo v0.4.0\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'go: finding golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '# golang.org/x/net/http2\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     '../../pkg/mod/golang.org/x/[email protected]/http2/transport.go:598:14: undefined: tls.Dialer\r\n' +
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>     'note: module requires Go 1.17',
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/deploy-cc-from-golang-source.test.ts 1>   stderr: ''

Cloud provider or hardware configuration:

Dev machine

Operating system name, version, build:

Use this command: printf "$(uname -srm)\n$(cat /etc/os-release)\n"

For example

$ $ printf "$(uname -srm)\n$(cat /etc/os-release)\n"
Linux 5.8.0-50-generic x86_64
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main @ today

Hyperledger Cactus Plugins/Connectors Used

Fabric

Additional context

N/A

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy

The text was updated successfully, but these errors were encountered:

This was initially a candidate for resolving the issue of hyperledger-cacti#914 but later that idea turned out to not work. At the end of the day we always thrive to work with the latest and greatest of all of our dependencies CVEs permitting so the upgrade can stay in as a valid change. Signed-off-by: Peter Somogyvari <[email protected]>

…#914 Primary change: ------------------ Pinned the buggy dependency to yesterday's version (the bug was introduced in this morning's build). This prevents today's version from being used and fixes the problem. Secondary change: -------------------- Upgraded the container image that's being used for the test to the one that has the fabric images pre-cached. This leads to faster test execution and lower probability of developers getting hit by the dreaded DockerHub rate limiting issue. Signed-off-by: Peter Somogyvari <[email protected]>

…#914 Primary change: ------------------ Pinned the buggy dependency to yesterday's version (the bug was introduced in this morning's build). This prevents today's version from being used and fixes the problem. Secondary change: -------------------- Upgraded the container image that's being used for the test to the one that has the fabric images pre-cached. This leads to faster test execution and lower probability of developers getting hit by the dreaded DockerHub rate limiting issue. Fixes hyperledger-cacti#914 Signed-off-by: Peter Somogyvari <[email protected]>