feat(keychain-vault): Fixing the incomplete endpoint methods #676
Labels
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Comments
petermetz
added
the
Keychain
|
@jagpreetsinghsasan Was the linked PR also resolving this issue or is there more to this one that still needs work? Just double checking if we should close the issue or not. |
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Jul 3, 2021
…cti#676 1. Adds the has/delete endpoints (which were missing completely) 2. Adds the get/set endpoints which were partially already implemented. 3. Moves the express dependency to be a dev dependency since we only use the types (e.g. only needed at compile time, not at runtime) 4. Adds specific test cases to the API client verifying the get/set/has/delete endpoints 5. Renames the getKeychainEntry and setKeychainEntry operationIDs to have a V1 suffix. Fixes hyperledger-cacti#676 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this issue
Jul 7, 2021
1. Adds the has/delete endpoints (which were missing completely) 2. Adds the get/set endpoints which were partially already implemented. 3. Moves the express dependency to be a dev dependency since we only use the types (e.g. only needed at compile time, not at runtime) 4. Adds specific test cases to the API client verifying the get/set/has/delete endpoints 5. Renames the getKeychainEntry and setKeychainEntry operationIDs to have a V1 suffix. Fixes #676 Signed-off-by: Peter Somogyvari <[email protected]>
izuru0
pushed a commit
to izuru0/cactus
that referenced
this issue
Jul 12, 2021
…cti#676 1. Adds the has/delete endpoints (which were missing completely) 2. Adds the get/set endpoints which were partially already implemented. 3. Moves the express dependency to be a dev dependency since we only use the types (e.g. only needed at compile time, not at runtime) 4. Adds specific test cases to the API client verifying the get/set/has/delete endpoints 5. Renames the getKeychainEntry and setKeychainEntry operationIDs to have a V1 suffix. Fixes hyperledger-cacti#676 Signed-off-by: Peter Somogyvari <[email protected]>
RafaelAPB
pushed a commit
to RafaelAPB/blockchain-integration-framework
that referenced
this issue
Mar 9, 2022
…cti#676 1. Adds the has/delete endpoints (which were missing completely) 2. Adds the get/set endpoints which were partially already implemented. 3. Moves the express dependency to be a dev dependency since we only use the types (e.g. only needed at compile time, not at runtime) 4. Adds specific test cases to the API client verifying the get/set/has/delete endpoints 5. Renames the getKeychainEntry and setKeychainEntry operationIDs to have a V1 suffix. Fixes hyperledger-cacti#676 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As a developer, I want to fix the following methods, enable them in installWebServices() method and fix the skipped test cases for the same
GetKeychainEntryEndpointV1
SetKeychainEntryEndpointV1
These files specifically
packages/cactus-plugin-keychain-vault/src/main/typescript/web-services/set-keychain-entry-endpoint-v1.ts (getExpressRequestHandler method)
packages/cactus-plugin-keychain-vault/src/main/typescript/web-services/get-keychain-entry-endpoint-v1.ts (getExpressRequestHandler method)
packages/cactus-plugin-keychain-vault/src/main/typescript/plugin-keychain-vault.ts (installWebServices method)
packages/cactus-plugin-keychain-vault/src/test/typescript/integration/plugin-keychain-vault.test.ts (skipped test cases)
Acceptance Criteria
The text was updated successfully, but these errors were encountered: