fix(sdk): build re-touches unused git_push.sh file #212
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
Developer_Experience
good-first-issue
Good for newcomers
Nice-to-Have
Describe the bug
The SDK build touches the
packages/cactus-sdk/src/main/typescript/generated/openapi/typescript-axios/git_push.sh
file which then shows up in the git diffs despite the file contents being equal as before (maybe it changes the executable flag on the file?)The second part of the problem is that we don't actually use/need/want this git_push.sh file at all since we have our own mechanisms in place for doing what that (otherwise handy little) script does for developers. So really the best would be to just ignore/exclude/delete that file altogether.
To Reproduce
npm run build
or any of the lighter build tasks that still end up running the OpenAPI generator tool for the SDK.Run
git status
and notice how the file was touched and that there is no real diff.Expected behavior
The build should not touch files that are under version control, or if it does, there should be an actual change to propagate.
Operating system name, version, build:
Use this command:
printf "$(uname -srm)\n$(cat /etc/os-release)\n"
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
92e7b0b
Hyperledger Cactus Plugins/Connectors Used
Additional context
Fairly certain that the root cause is the OpenAPI generator doing something it should not (or something that is needed but we don't use it).
cc: @takeutak @jonathan-m-hamilton @sfuji822
The text was updated successfully, but these errors were encountered: