Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cactus-plugin-connector-iroha): Implement tests for openapi validation #1331

Closed
elenaizaguirre opened this issue Sep 14, 2021 · 0 comments · Fixed by #1332
Closed

fix(cactus-plugin-connector-iroha): Implement tests for openapi validation #1331

elenaizaguirre opened this issue Sep 14, 2021 · 0 comments · Fixed by #1332
Assignees
@elenaizaguirre
Labels
bug Something isn't working Iroha Bugs/features related to the Iroha ledger connector plugin

Comments

@elenaizaguirre
Copy link
Contributor

elenaizaguirre commented Sep 14, 2021 •
edited
Loading

Describe the bug

After implement openapi validation in plugins endpoints in cmd-api-server (#847), we must ensure that all endpoints in cactus-plugin-ledger-iroha are validated according package openapi specs.

Specific tests are needed.

To Reproduce

Call endpoints throught package API client with right and wrong requests.

Expected behavior

Right requests should return status code 200 and wrong requests should return status code 400.

Hyperledger Cactus Plugins/Connectors Used

  • cactus-plugin-ledger-iroha
@elenaizaguirre elenaizaguirre added the bug Something isn't working label Sep 14, 2021
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 14, 2021
@elenaizaguirre
fix: openapi validation test for iroha plugin
2b9aae7 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
@elenaizaguirre elenaizaguirre mentioned this issue Sep 14, 2021
Merged
@petermetz petermetz added the Iroha Bugs/features related to the Iroha ledger connector plugin label Sep 14, 2021
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 17, 2021
@elenaizaguirre
fix: openapi validation test for iroha plugin
f74bbba 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 22, 2021
@elenaizaguirre
fix: openapi validation test for iroha plugin
fbd5f27 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 27, 2021
@elenaizaguirre
fix: openapi validation test for iroha plugin
2116dcb 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Sep 28, 2021
@elenaizaguirre
fix: openapi validation test for iroha plugin
58eb038 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
petermetz pushed a commit that referenced this issue Sep 28, 2021
@elenaizaguirre @petermetz
fix: openapi validation test for iroha plugin
6deed6d 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes #1331

Related with #847

Signed-off-by: Elena Izaguirre <[email protected]>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Sep 29, 2021
@elenaizaguirre @Leeyoungone
fix: openapi validation test for iroha plugin
81e8c51 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
brioux pushed a commit to brioux/cactus that referenced this issue Oct 4, 2021
@elenaizaguirre @brioux
fix: openapi validation test for iroha plugin
9ecc945 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@elenaizaguirre @RafaelAPB
fix: openapi validation test for iroha plugin
54a5ef6 
Includes test for endpoint runTransactionV1
with test cases:
  - Right request
  - Request including an invalid parameter
  - Request without a required parameter

Closes hyperledger-cacti#1331

Related with hyperledger-cacti#847

Signed-off-by: Elena Izaguirre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenaizaguirre elenaizaguirre

Labels
bug Something isn't working Iroha Bugs/features related to the Iroha ledger connector plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: openapi validation test for iroha plugin elenaizaguirre/cactus
2 participants
@petermetz @elenaizaguirre