Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-api-server): Cactus-Cockpit to be off by default #1239

Closed
m-courtin opened this issue Aug 18, 2021 · 0 comments · Fixed by #1304
Closed

fix(cmd-api-server): Cactus-Cockpit to be off by default #1239

m-courtin opened this issue Aug 18, 2021 · 0 comments · Fixed by #1304
Assignees
@AzaharaC
Labels
API_Server bug Something isn't working Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Security Related to existing or potential security vulnerabilities
Milestone
v0.10.0

Comments

@m-courtin
Copy link
Contributor

Describe the bug

After a first installation of latest cactus version the Cactus-Cockpit is not completely disabled / removed. In the documentation (build.md) you will see "After starting the API server, you will see in the logs that plugins were loaded and that the API is reachable on the port you specified (4000 by default) and the Web UI (Cockpit) is reachable through port on the port your config specified (3000 by default)."

Also the Cactus API-Server server shows in the logs "[2021-08-16T13:49:52.029Z] INFO (api-server): Cactus Cockpit reachable https://127.0.0.1:3000"

To Reproduce

  • Install latest version of Cactus
  • Execute "npm run generate-api-server-config" as written in documentation
  • Execute "npm run start:api-server" as written in documentation

Expected behaviour

As the Cactus - Cockpit should be disabled / removed, Cactus API-Server logs should not show that Cockpit is reachable at endpoint xyz and documentation should be updated accordingly.
@m-courtin m-courtin added the bug Something isn't working label Aug 18, 2021
@petermetz petermetz added API_Server Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Security Related to existing or potential security vulnerabilities labels Aug 18, 2021
@m-courtin m-courtin changed the title Cactus - Cockpit is not completely disabled / removed fix(cmd-api-server): Cactus-Cockpit to be off by default Aug 19, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Aug 31, 2021
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 6, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
cd70023 
Signed-off-by: AzaharaC <[email protected]>
@AzaharaC AzaharaC mentioned this issue Sep 6, 2021
Merged
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 7, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
609c934 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 8, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
e43ee12 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 13, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
090492f 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 16, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
994a9ee 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Sep 29, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
a90f012 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Oct 28, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
5e73ecf 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Nov 4, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
e952e1d 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Nov 15, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
cc6c74c 
Signed-off-by: AzaharaC <[email protected]>
AzaharaC added a commit to AzaharaC/cactus that referenced this issue Nov 17, 2021
@AzaharaC
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
e84903c 
Signed-off-by: AzaharaC <[email protected]>
petermetz pushed a commit that referenced this issue Nov 17, 2021
@AzaharaC @petermetz
fix(cmd-api-server): cockpit off by default #1239
10344b5 
Signed-off-by: AzaharaC <[email protected]>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 19, 2021
@AzaharaC @Leeyoungone
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
91c95c1 
Signed-off-by: AzaharaC <[email protected]>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 19, 2021
@AzaharaC @Leeyoungone
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
d2e7b53 
Signed-off-by: AzaharaC <[email protected]>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 19, 2021
@AzaharaC @Leeyoungone
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
0111a5e 
Signed-off-by: AzaharaC <[email protected]>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Nov 19, 2021
@AzaharaC @Leeyoungone
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
8b1a7bb 
Signed-off-by: AzaharaC <[email protected]>
Signed-off-by: Youngone Lee <[email protected]>
awadhana pushed a commit to awadhana/cactus that referenced this issue Nov 24, 2021
@AzaharaC @awadhana
fix(cmd-api-server): cockpit off by default hyperledger-cacti#1239
96f9b38 
Signed-off-by: AzaharaC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzaharaC AzaharaC

Labels
API_Server bug Something isn't working Developer_Experience good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

fix(cmd-api-server): cockpit off by default #1239 AzaharaC/cactus
3 participants
@petermetz @AzaharaC @m-courtin