feat(cactus-plugin-ledger-connector-ethereum): refactor connector API #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Dismissed
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Fixed
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Dismissed
Show resolved
Hide resolved
petermetz
reviewed
Aug 25, 2023
packages/cactus-plugin-ledger-connector-ethereum/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
outSH
force-pushed
the
eth_connector_refactor_pr
branch
from
fb3cdb5 to
4540c1b
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 18, 2023
- Return JSON error before checking for Error instance in safeStringifyException
(for cases when custom errror extends `Error` with `toJSON()` method)
- Move artillery dependency up to the root (since its common tool depdenecy)
- Add web3js http/ws provider options to connector.
- Make http provider optional (can run on ws web3js provider only)
- Don't register async endpoints when WS provider is not available.
- Return 400 for invalid responses from ethereum ledger (to distinguish from connector errors)
- In docker `geth-all-in-one` allow overwriting of default options when starting the ledger.
- Add artillery stress test scripts
- Template config and artillery functions file
- Common environment setup file
- CLI for running the test environment on a separate machine.
- Jest test to run quickly stress test on same machine.
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
|
This PR/issue depends on:
|
outSH
force-pushed
the
eth_connector_refactor_pr
branch
from
4540c1b to
1171f97
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 5, 2023
- Refactor persistence ethereum plugin to use openapi ethereum connector
instead of ethereum-socketio.
- Upgrade web3js to 4.X in both persistence plugin and its tests.
- Update persistence plugin dependency list.
- Recompile base token contracts in persistence plugin to match format
required by ethereum connector (full compilation output, not just ABI)
- Minor fix in ethereum connector to return empty transactions
array instead of undefined.
- Fix minor runtime issues in geth-test-ledger
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
eth_connector_refactor_pr
branch
from
1171f97 to
74327d0
Compare
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Co-authored-by: Peter Somogyvari <[email protected]>
1. Updated the yarn.lock file to reflect the changes in the package.json
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
eth_connector_refactor_pr
branch
from
74327d0 to
cda279f
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 16, 2023
- Return JSON error before checking for Error instance in safeStringifyException
(for cases when custom errror extends `Error` with `toJSON()` method)
- Move artillery dependency up to the root (since its common tool depdenecy)
- Add web3js http/ws provider options to connector.
- Make http provider optional (can run on ws web3js provider only)
- Don't register async endpoints when WS provider is not available.
- Return 400 for invalid responses from ethereum ledger (to distinguish from connector errors)
- In docker `geth-all-in-one` allow overwriting of default options when starting the ledger.
- Add artillery stress test scripts
- Template config and artillery functions file
- Common environment setup file
- CLI for running the test environment on a separate machine.
- Jest test to run quickly stress test on same machine.
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Oct 16, 2023
- Return JSON error before checking for Error instance in safeStringifyException
(for cases when custom errror extends `Error` with `toJSON()` method)
- Move artillery dependency up to the root (since its common tool depdenecy)
- Add web3js http/ws provider options to connector.
- Make http provider optional (can run on ws web3js provider only)
- Don't register async endpoints when WS provider is not available.
- Return 400 for invalid responses from ethereum ledger (to distinguish from connector errors)
- In docker `geth-all-in-one` allow overwriting of default options when starting the ledger.
- Add artillery stress test scripts
- Template config and artillery functions file
- Common environment setup file
- CLI for running the test environment on a separate machine.
- Jest test to run quickly stress test on same machine.
Depends on #2631
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 17, 2023
- Refactor persistence ethereum plugin to use openapi ethereum connector
instead of ethereum-socketio.
- Upgrade web3js to 4.X in both persistence plugin and its tests.
- Update persistence plugin dependency list.
- Recompile base token contracts in persistence plugin to match format
required by ethereum connector (full compilation output, not just ABI)
- Minor fix in ethereum connector to return empty transactions
array instead of undefined.
- Fix minor runtime issues in geth-test-ledger
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Oct 17, 2023
- Refactor persistence ethereum plugin to use openapi ethereum connector
instead of ethereum-socketio.
- Upgrade web3js to 4.X in both persistence plugin and its tests.
- Update persistence plugin dependency list.
- Recompile base token contracts in persistence plugin to match format
required by ethereum connector (full compilation output, not just ABI)
- Minor fix in ethereum connector to return empty transactions
array instead of undefined.
- Fix minor runtime issues in geth-test-ledger
Depends on #2631
Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
- Return JSON error before checking for Error instance in safeStringifyException
(for cases when custom errror extends `Error` with `toJSON()` method)
- Move artillery dependency up to the root (since its common tool depdenecy)
- Add web3js http/ws provider options to connector.
- Make http provider optional (can run on ws web3js provider only)
- Don't register async endpoints when WS provider is not available.
- Return 400 for invalid responses from ethereum ledger (to distinguish from connector errors)
- In docker `geth-all-in-one` allow overwriting of default options when starting the ledger.
- Add artillery stress test scripts
- Template config and artillery functions file
- Common environment setup file
- CLI for running the test environment on a separate machine.
- Jest test to run quickly stress test on same machine.
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
- Refactor persistence ethereum plugin to use openapi ethereum connector
instead of ethereum-socketio.
- Upgrade web3js to 4.X in both persistence plugin and its tests.
- Update persistence plugin dependency list.
- Recompile base token contracts in persistence plugin to match format
required by ethereum connector (full compilation output, not just ABI)
- Minor fix in ethereum connector to return empty transactions
array instead of undefined.
- Fix minor runtime issues in geth-test-ledger
Depends on hyperledger-cacti#2631
Signed-off-by: Michal Bajer <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invokeContractendpoint that can accept multiple methods ofsupplying contract definition (directly, from keychain, etc..).
deployContractmethod.safeStringifyExceptionfunction to better handle axios errors(and other custom exceptions that support
toJSON()method.).Cactiwork in entire connector (except for package name)Depends on #2630
Signed-off-by: Michal Bajer [email protected]