build(deps): upgrade web3 project-wide to v1.6.1 #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micoferdinand98
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Jul 14, 2023
petermetz
force-pushed
the
micoferdinand98/issue2332
branch
from
b8b81eb to
2ed654e
Compare
Update from Peter: I needed to do an unsafe cast because that was the least bad option (other option was to make a breaking change in the quourm connector's API). The issue opened for tracking a proper resolution to this is titled as: refactor(connector-quorum): make Web3BlockHeader.receiptRoot optional hyperledger-cacti#2555 and the link to it on GitHub is https://github.com/hyperledger/cacti/issues/2555 Fixes hyperledger-cacti#2332 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
micoferdinand98/issue2332
branch
from
2ed654e to
f8aef94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from Peter: I needed to do an unsafe cast because that was the least
bad option (other option was to make a breaking change in the quourm
connector's API).
The issue opened for tracking a proper resolution to this is titled as:
refactor(connector-quorum): make Web3BlockHeader.receiptRoot optional #2555
and the link to it on GitHub is https://github.com/hyperledger/cacti/issues/2555
Fixes #2332
Co-authored-by: Peter Somogyvari [email protected]
Signed-off-by: Peter Somogyvari [email protected]