Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(persistence-ethereum): migrate to separate db schema #3347

Merged

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jun 21, 2024

  • Move all database entities relating to ethereum persistence plugin to
    a seprate schema. Adjust all the files the test to work as expected after
    that change.
  • Remove sample SQL data from GUI package, one from persistence packages should
    be used instead.
  • Upgrade web3-utils in persistence-ethereum to fix a bug when running the
    standalone script.

Depends on https://github.com/hyperledger/cacti/pull/3340

Signed-off-by: Michal Bajer [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link

This PR/issue depends on:

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM but please throw the ball back for another review once the parent PRs hve been merged and the conflicts resolved!

outSH added a commit to outSH/cactus that referenced this pull request Jul 11, 2024
- Read gui supabase connection information from environment variable.
  Include `.env` files in common `.gitignore` file.
  Change ledger-browser typescript target and module to `esnext` to use
  vite environment variables.
- Read app configuration from the supabase DB.
- Add button on home page for adding new application.
  Clicking on it will open dialog with setup wizzard.
  User must filter apps by it's group (step 1), select the app (step 2),
  input common app configuration data (step 3)
  and lastly input app-specific configuration (JSON format).
- Add button to configure already added app. It opens a dialog that allows
  editing app details in the database.
  It also contains a button for deleting the app (after confirmation).
- Show full screen error message with setup guidelines
  when app has failed to connect to supabase.
- Clean up supabase type files, move app-related typedefs to specific app dirs.

Depends on hyperledger-cacti#3347

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH force-pushed the move_eth_persistence_to_separate_schema_pr branch from 81d7bfd to abfe25b Compare July 30, 2024 12:03
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH outSH force-pushed the move_eth_persistence_to_separate_schema_pr branch from abfe25b to 57608bd Compare August 8, 2024 09:30
@outSH outSH requested a review from petermetz August 8, 2024 09:32
@outSH
Copy link
Contributor Author

outSH commented Aug 8, 2024

@petermetz Done, ready for review :)

@outSH outSH enabled auto-merge (rebase) August 9, 2024 15:47
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Nice, LGTM!

- Move all database entities relating to ethereum persistence plugin to
  a seprate schema. Adjust all the files the test to work as expected after
  that change.
- Remove sample SQL data from GUI package, one from persistence packages should
  be used instead.
- Upgrade web3-utils in persistence-ethereum to fix a bug when running the
  standalone script.

Depends on hyperledger-cacti#3340

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the move_eth_persistence_to_separate_schema_pr branch from 57608bd to 3aca556 Compare August 9, 2024 23:23
@petermetz petermetz disabled auto-merge August 9, 2024 23:23
@outSH outSH merged commit b160c52 into hyperledger-cacti:main Aug 12, 2024
140 of 143 checks passed
outSH added a commit to outSH/cactus that referenced this pull request Aug 12, 2024
- Read gui supabase connection information from environment variable.
  Include `.env` files in common `.gitignore` file.
  Change ledger-browser typescript target and module to `esnext` to use
  vite environment variables.
- Read app configuration from the supabase DB.
- Add button on home page for adding new application.
  Clicking on it will open dialog with setup wizzard.
  User must filter apps by it's group (step 1), select the app (step 2),
  input common app configuration data (step 3)
  and lastly input app-specific configuration (JSON format).
- Add button to configure already added app. It opens a dialog that allows
  editing app details in the database.
  It also contains a button for deleting the app (after confirmation).
- Show full screen error message with setup guidelines
  when app has failed to connect to supabase.
- Clean up supabase type files, move app-related typedefs to specific app dirs.

Depends on hyperledger-cacti#3347

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this pull request Aug 12, 2024
- Read gui supabase connection information from environment variable.
  Include `.env` files in common `.gitignore` file.
  Change ledger-browser typescript target and module to `esnext` to use
  vite environment variables.
- Read app configuration from the supabase DB.
- Add button on home page for adding new application.
  Clicking on it will open dialog with setup wizzard.
  User must filter apps by it's group (step 1), select the app (step 2),
  input common app configuration data (step 3)
  and lastly input app-specific configuration (JSON format).
- Add button to configure already added app. It opens a dialog that allows
  editing app details in the database.
  It also contains a button for deleting the app (after confirmation).
- Show full screen error message with setup guidelines
  when app has failed to connect to supabase.
- Clean up supabase type files, move app-related typedefs to specific app dirs.

Depends on #3347

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants