feat(ledger-browser): refactor home page #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jun 21, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Add `sample-persistence-plugin-setup` script for performing end-to-end tests of the persistence ethereum plugin. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on hyperledger-cacti#3340 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
|
This PR/issue depends on:
|
outSH
force-pushed
the
gui_new_home_page_pr
branch
from
45ab083 to
19af4b0
Compare
petermetz
approved these changes
Jul 25, 2024
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 30, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Add `sample-persistence-plugin-setup` script for performing end-to-end tests of the persistence ethereum plugin. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on hyperledger-cacti#3340 Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
gui_new_home_page_pr
branch
from
19af4b0 to
4632305
Compare
outSH
force-pushed
the
gui_new_home_page_pr
branch
from
4632305 to
9c99b92
Compare
- Remove status apps, its functionality has been moved to the home page. - Add status components for persistence apps. - Add home page that contains cards for each configured app. Clicking on it naviagtes to specific app, clicking on Status button shows status component. - Remove app drawer, replace it with a button that navigates to root path (i.e. the home app, navigation between apps is handled here). - Remove all the remaining dead and legacy code, apply small structure upgrades. - Since this PR removes all old code, and all the current code was written by me and Tomasz, I've also removed previous inactive package contributors. Depends on hyperledger-cacti#3320 Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
gui_new_home_page_pr
branch
from
9c99b92 to
5bab29c
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 8, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on hyperledger-cacti#3340 Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Aug 9, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on hyperledger-cacti#3340 Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
that referenced
this pull request
Aug 12, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on #3340 Signed-off-by: Michal Bajer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naviagtes to specific app, clicking on Status button shows status component.
(i.e. the home app, navigation between apps is handled here).
me and Tomasz, I've also removed previous inactive package contributors.
Depends on #3320
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.