Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-example-tcs-huawei): remove deprecated sample app #3157

Closed
outSH opened this issue Mar 29, 2024 · 1 comment · Fixed by #3158
Closed

feat(cactus-example-tcs-huawei): remove deprecated sample app #3157

outSH opened this issue Mar 29, 2024 · 1 comment · Fixed by #3158
Assignees
Labels
enhancement New feature or request

Comments

@outSH
Copy link
Contributor

outSH commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
cactus-example-tcs-huawei is using cactus-plugin-ledger-connector-go-ethereum-socketio and cactus-plugin-ledger-connector-tcs-huawei-socketio, both of them will be removed soon as well. Ths sample app can't exist without them.

See #3155 for more details on motivation and future of this package!

Deprecation and package removal is not final

If there's a need to bring some of these packages back, or if the package gets refactored so that it matches
the state of other cacti packages, then the package can be restored. Removed packages can still be accessed by checking-out the state of this repo before the removal (I'll add appropriate commits next to the removed plugins on the list as the PR get merged).

@outSH outSH added the enhancement New feature or request label Mar 29, 2024
@outSH outSH self-assigned this Mar 29, 2024
outSH added a commit to outSH/cactus that referenced this issue Mar 29, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.

Closes: hyperledger-cacti#3157
Part of: hyperledger-cacti#3155

Signed-off-by: Michal Bajer <[email protected]>
@petermetz
Copy link
Contributor

@outSH Thank you! I posted some additional details on the pull request itself just to make sure everyone is in the know about the details of our decision here and that the removal is just temporary.

outSH added a commit to outSH/cactus that referenced this issue Apr 2, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Jun 20, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit that referenced this issue Jun 20, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue #3155 on github for more details on context and reasoning
    of this decision.

Closes: #3157

Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Jul 30, 2024
- `cactus-example-tcs-huawei` is using
    `cactus-plugin-ledger-connector-go-ethereum-socketio` and
    `cactus-plugin-ledger-connector-tcs-huawei-socketio` which will
    be removed as well. Ths sample app can't exist on it's own.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger-cacti#3155 on github for more details on context and reasoning
    of this decision.

Closes: hyperledger-cacti#3157

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants