feat(cactus-plugin-ledger-connector-ethereum): support London fork gas prices #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Dismissed
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Dismissed
Show resolved
Hide resolved
...tus-plugin-ledger-connector-ethereum/src/main/typescript/plugin-ledger-connector-ethereum.ts
Dismissed
Show resolved
Hide resolved
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 22, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Sep 11, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
|
This PR/issue depends on:
|
outSH
force-pushed
the
london_fork_feat_pr
branch
from
9a7dc2c
to
b78f835
Compare
outSH
force-pushed
the
london_fork_feat_pr
branch
from
b78f835
to
bce2858
Compare
petermetz
approved these changes
Oct 2, 2023
…s prices - Add legacy and EIP1559 gas configuration options to transaction requests. - Legacy gas configuration is updated to EIP1559 using the same logic as web3 libraries. - Update the tests to work with new API. - Added test suite to test new features - `geth-transact-and-gas-fees.test.ts` Depends on: hyperledger-cacti#2581 Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
london_fork_feat_pr
branch
from
bce2858
to
80a89dd
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 3, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 10, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Oct 10, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Co-authored-by: Peter Somogyvari <[email protected]>
1. Updated the yarn.lock file to reflect the changes in the package.json
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
- Refactor to single `invokeContract` endpoint that can accept multiple methods of
supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
(and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)
Co-authored-by: Peter Somogyvari <[email protected]>
1. Updated the yarn.lock file to reflect the changes in the package.json
Depends on: hyperledger-cacti#2630
Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geth-transact-and-gas-fees.test.tsDepends on #2581
Signed-off-by: Michal Bajer [email protected]