Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odap-plugin): fix bug in #2198 #2205

Merged

Conversation

AndreAugusto11
Copy link
Contributor

@AndreAugusto11 AndreAugusto11 commented Nov 14, 2022

Two gateways were using the same database, which was causing a test to fail.

When retrieving the logs since a certain timestamp, there were logs from the other gateway. This caused the number of logs retrieved to be higher than what was supposed to be.

Fixes #2198

Signed-off-by: André Augusto [email protected]

@AndreAugusto11
Copy link
Contributor Author

AndreAugusto11 commented Nov 15, 2022

@petermetz the cactus-plugin-ledger-connector-iroha is failing the CI for some reason

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 LGTM on the code diff but please make sure to have the commit message contain at least the same level of information as the PR description answering the What/Why questions in general.

Also make sure to use the Fixes #??? syntax both in the PR description and in the commit message to signify that this PR is fixing the specific issue and have GitHub auto-close it for us (otherwise someone manually has to hunt down the issue itself and close it)

@AndreAugusto11 AndreAugusto11 force-pushed the fix-odap-plugin-knex-bug branch 3 times, most recently from 56ecd88 to 81714ce Compare November 15, 2022 20:48
@AndreAugusto11 AndreAugusto11 requested review from petermetz and removed request for sandeepnRES, jagpreetsinghsasan and izuru0 November 20, 2022 20:07
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 Thank you for the updates! LGTM

…ng the same database

* getLogsMoreRecentThanTimestamp() was returning more logs than supposed because
* both gateways were using the same database, instead of each having its own

Signed-off-by: André Augusto <[email protected]>
@petermetz petermetz merged commit 9da24a0 into hyperledger-cacti:main Nov 21, 2022
@AndreAugusto11 AndreAugusto11 deleted the fix-odap-plugin-knex-bug branch November 21, 2022 07:51
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Nov 22, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Dependent on hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 18, 2022
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Jan 8, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Jan 8, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Signed-off-by: André Augusto <[email protected]>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this pull request Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this pull request Aug 16, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz pushed a commit to AndreAugusto11/cacti that referenced this pull request Aug 17, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz pushed a commit that referenced this pull request Aug 17, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: #2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this pull request Dec 21, 2023
This application demonstrates a CBDC bridging between a Fabric and a Besu network
using the ODAP business logic plugin, a protocol under standardization for cross-chain
asset transfers in the IETF.

The goal is to demonstrate the use of npm packages of Cactus so that anyone can
build a solution on top of Cacti.

Summary:
* CBDC application backend (set up underlying ledgers and deployment of smart contracts)
* Add support for multiple organizations in some operations in the FabricTestLedger
* Add support for minting some Ether to a given address in the BesuTestLedger

Future Work:
* CBDC app UI demonstrating the use of the app is, for now, only available as docker image
* A Dockerfile for the backend will be created as soon as this package is published to npm
* More documentation will be added in the next weeks

Depends on: hyperledger-cacti#2205

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(plugin-odap-hermes): fix flaky recovery update test
3 participants