Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vscode/devcontainer): unexpected exit stdout /etc/passwd
1. Moved away from trying to handroll an Ubuntu-22.04 image for the dev container and instead used the "features" feature (no pun intended) of the dev container spec: https://code.visualstudio.com/blogs/2022/09/15/dev-container-features 2. This produces a container that builds and launches reliably without the issues the previous version was suffering from (which was that to some people the container would just exit randomly during the launch) 3. Our future goal of having the dev container being built in a reproducible way is still not achieved, but we've gotten closer because in the meantime while working on this issue it was discovered that we can re-build the images directly from the CLI by using the dev container CLI package: https://github.com/devcontainers/cli 4. The upside of not building the image from scratch is that we can count on future improvements/maintenance from others who are working on these images. 5. The downside of not building the image from scratch is that if we end up finding something that does not work due to the customizations, it might be more difficult to figure that out compared to if we had just build our own. 6. It is hard to predcit right now whether 4) or 5) will end up being having the stronger effect, but we can cross that bridge when we get to it. 7. In the meantime I've started working on a contribution to the dev container CLI itself for a dockerfile ejection feature (meaning that we'll be able to render a single Dockerfile for the dev container (that right now the CLI only stores/uses internally in it's own code at runtime). This eject feature will be good for debugging purposes in case anything goes wrong with the image in the future. 8. Also added a publishing workflow action that will build the dev container image on the main branch when there is a release tag (v*) issued. Fixes #2404 Signed-off-by: Peter Somogyvari <[email protected]>
- Loading branch information