[quorum] introduce helm chart deployment capability #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhkumarkardam
requested review from
sownak,
suvajit-sarkar,
jagpreetsinghsasan,
arsulegai,
weihong-ou and
adityajoshi12
as code owners
sownak
requested changes
Feb 20, 2024
platforms/hyperledger-besu/charts/besu-tessera-node/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
platforms/hyperledger-besu/charts/besu-tessera-node/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
platforms/quorum/charts/quorum-genesis/templates/genesis-job-init.yaml
Outdated
Show resolved
Hide resolved
saurabhkumarkardam
force-pushed
the
goquorum-2484
branch
3 times, most recently
from
8274989
to
5f853e5
Compare
saurabhkumarkardam
force-pushed
the
goquorum-2484
branch
4 times, most recently
from
bdd2241
to
4c69946
Compare
sownak
requested changes
Feb 27, 2024
platforms/quorum/charts/values/noproxy-and-novault/txnode-sec.yaml
Outdated
Show resolved
Hide resolved
saurabhkumarkardam
force-pushed
the
goquorum-2484
branch
2 times, most recently
from
71f3851
to
e19c40c
Compare
This commit enhances the deployment process for the Quorum Distributed Ledger Technology (DLT) network by exclusively leveraging Helm charts. Four new Helm charts have been introduced to streamline the deployment process: 1. quorum-genesis: Initializes the network with specific requirements. 2. quorum-node: Starts the network and allows adding new nodes. 3. quorum-tessera-node: Facilitates privacy by enabling transaction encryption using Tessera. 4. quorum-tlscert-gen: Enables secure access to the node via HTTPS. Each chart comes with a README to help users customize the network. These changes make deploying and managing the Quorum DLT network smoother with Helm. Other Improvements: - Added error handling to ensure clean uninstallation of the besu-genesis and besu-tlscert-gen charts. - Updated the README's API Call section. fixes hyperledger-bevel#2484 Signed-off-by: saurabhkumarkardam <[email protected]>
saurabhkumarkardam
force-pushed
the
goquorum-2484
branch
from
e19c40c
to
7e4e834
Compare
sownak
reviewed
Mar 4, 2024
| @@ -145,4 +169,5 @@ To deploy the proposed validator chart, we need to deploy the Besu node chart fi | |||
|
|
|||
| ```bash | |||
| helm install validator-5 ./besu-propose-validator --namespace supplychain-bes --values besu-propose-validator/values.yaml | |||
| >>>>>>> upstream/develop | |||
| memory: "{{ .Values.node.goquorum.resources.memLimit }}" | ||
| volumeMounts: | ||
| - name: static-nodes | ||
| mountPath: /{{ .Release.Name }}/staticNode/ |
There was a problem hiding this comment.
Don't think the mountpaths should have variables. Just because it was done previously does not make it right. Please use static paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(quorum): introduce helm chart deployment capability
fixes #2484