Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Privacy ATs - have been disabled for some time #7347

Closed
macfarla opened this issue Jul 18, 2024 · 6 comments · Fixed by #7530
Closed

Remove Privacy ATs - have been disabled for some time #7347

macfarla opened this issue Jul 18, 2024 · 6 comments · Fixed by #7530
Assignees
@nettad @pr9t
Labels
good first issue Good for newcomers help wanted Extra attention is needed snack Smaller coding task - less than a day for an experienced dev

Comments

@macfarla
Copy link
Contributor

macfarla commented Jul 18, 2024 •
edited
Loading

Remove privacy AT classes and associated testing resources - look for AT classes that extend this base class -
java/org/hyperledger/besu/tests/acceptance/dsl/privacy/PrivacyAcceptanceTestBase.java
@macfarla macfarla added good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev help wanted Extra attention is needed labels Jul 18, 2024
@macfarla macfarla mentioned this issue Jul 23, 2024
Closed
@pr9t
Copy link
Contributor

pr9t commented Aug 27, 2024

Hey, I am interested in this issue. Please assign this to me.

@pr9t
Copy link
Contributor

pr9t commented Aug 27, 2024

I have found these classes that extend the base class. Can I remove these classes and the base class?

  1. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/FlexiblePrivacyAcceptanceTestBase.java
  2. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/EnclaveErrorAcceptanceTest.java
  3. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/BftPrivacyClusterAcceptanceTest.java
  4. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/PluginPrivacySigningAcceptanceTest.java
  5. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyClusterAcceptanceTest.java
  6. acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/privacy/PrivacyGroupAcceptanceTest.java
  7. acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/privacy/ParameterizedEnclaveTestBase.java

@nettad
Copy link

nettad commented Aug 27, 2024

I would like this issue assigned to me.

@macfarla
Copy link
Contributor Author

Correct @pr9t those classes can all be removed. Assigned you and @nettad to the issue

@pr9t pr9t mentioned this issue Aug 28, 2024
Merged
8 tasks
@macfarla
Copy link
Contributor Author

macfarla commented Sep 4, 2024

There are still some privacy related ATs that can be deleted. eg PrivacyGroupTest, MultiTenancyAcceptanceTest

2 ways to find them - run ./gradlew acceptanceTestPrivacy and see what tests get picked up
OR
look for privacy folders under acceptance-tests dir- all tests within this dir can be deleted.

@macfarla macfarla reopened this Sep 4, 2024
@macfarla
Copy link
Contributor Author

fixed by #7569

@macfarla macfarla mentioned this issue Oct 21, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nettad nettad

@pr9t pr9t

Labels
good first issue Good for newcomers help wanted Extra attention is needed snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Removed Privacy ATs pr9t/besu
3 participants
@nettad @macfarla @pr9t