Sequenced pool synonym for legacy pool #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitehead <[email protected]>
|
Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
matthew1001
added
the
doc-change-required
|
Re. docs, I think the https://besu.hyperledger.org/public-networks/concepts/transactions/pool topic probably ought to have a new sub-heading for the sequenced pool. We didn't have one before for the legacy pool but with recent changes to the legacy pool we should try to describe the use-cases the sequenced pool is aimed at and how it differs from the layered pool. I'd be happy to provide some words to help with that docs topic. |
Signed-off-by: Matthew Whitehead <[email protected]>
macfarla
approved these changes
Dec 12, 2023
|
|
||
| CommandLineUtils.failIfOptionDoesntMeetRequirement( | ||
| commandLine, | ||
| "Could not use layered transaction pool options with legacy implementation", | ||
| !txPoolImplementation.equals(LEGACY), | ||
| "Could not use layered transaction pool options with legacy or sequenced implementation", |
There was a problem hiding this comment.
Suggested change
| "Could not use layered transaction pool options with legacy or sequenced implementation", | |
| "Could not use layered transaction pool options with legacy (sequenced) implementation", |
There was a problem hiding this comment.
Yeah it's difficult balancing the fact that we don't want to make the sequenced pool sound like it's the "legacy" option, even though in reality they are the same implementation. At some point the legacy option will be removed entirely so we'll update these messages to just talk about sequenced in the future. Personally I'd prefer to leave it as "legacy or sequenced" for now, but happy to discuss further and we can always raise another PR to re-word if we need to?
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]>
Thanks for the comments @macfarla. I've added a reply about the warning message wording. Re. change log entry, I've added a one-liner to it already. Did you want anything more substantial, like Fabio did for the layered pool in |
…hyperledger#6205) revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 12, 2023
* Sequenced pool synonym for legacy pool Signed-off-by: Matthew Whitehead <[email protected]> * Class rename Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> * Add SEQUENCED to config overview test Signed-off-by: Matthew Whitehead <[email protected]> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (hyperledger#6205) revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]>
jflo
added a commit
that referenced
this pull request
Dec 12, 2023
* New cli options to limit rewards return by eth_feeHistory (#6202) * [#5851] Add error messages on authentication failures with username and password (#6212) * Add a constant for the 'password' * Add error messages on authentication failures with username and password Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: jflo <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: David Lutzardo <[email protected]> Signed-off-by: David Lutzardo <[email protected]> * Add test to check empty login and check response in body is not empty Signed-off-by: David Lutzardo <[email protected]> * Correct format (spotless) Signed-off-by: David Lutzardo <[email protected]> * Update ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: David Lutzardo <[email protected]> * Update ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: David Lutzardo <[email protected]> * Update JsonRpcHttpServiceLoginTest.java use containsIgnoringCase Signed-off-by: David Lutzardo <[email protected]> * Add a CHANGELOG entry for PR 6212 Signed-off-by: David Lutzardo <[email protected]> --------- Signed-off-by: David Lutzardo <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * Add RockDB Subcommand for printing usage per column family (#6185) * Add RockDB Subcommand for printing usage per column family Signed-off-by: Simon Dudley <[email protected]> * changed output to follow a MD table notation. Signed-off-by: Gabriel Fukushima <[email protected]> --------- Signed-off-by: Gabriel Fukushima <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Signed-off-by: jflo <[email protected]> * Deprecation warning if Forest pruning is enabled (#6230) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * Fix the annoying "Errors occurred while build effective model" during builds (#6241) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * Run ATs sequentially (#6244) Signed-off-by: Gabriel Fukushima <[email protected]> Signed-off-by: jflo <[email protected]> * fix: double calls to trace{Start,End}Transaction (#6247) Signed-off-by: delehef <[email protected]> Signed-off-by: jflo <[email protected]> * migrate to junit5 (#6234) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * fixes for problems discovered in main (#6248) Signed-off-by: garyschulte <[email protected]> Signed-off-by: jflo <[email protected]> * Pki - migrate to junit 5 (#6235) * migrate to junit5 Signed-off-by: Sally MacFarlane <[email protected]> * fix: double calls to trace{Start,End}Transaction (#6247) Signed-off-by: Franklin Delehelle <[email protected]> * migrate to junit5 (#6234) Signed-off-by: Sally MacFarlane <[email protected]> * fixes for problems discovered in main (#6248) Signed-off-by: garyschulte <[email protected]> * fixed test comparing size of collection Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: garyschulte <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: garyschulte <[email protected]> Signed-off-by: jflo <[email protected]> * junit 5 ftw (#6253) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * removed unnecessary use of static temp dir (#6251) * don't use static tempdir Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * Remove parallelism usage from mainnet AT (#6252) * Remove parallelism usage from mainnet AT Signed-off-by: Gabriel Fukushima <[email protected]> * Increase parallelism usage from mainnet AT Signed-off-by: Gabriel Fukushima <[email protected]> * Add the split command back Signed-off-by: Gabriel Fukushima <[email protected]> --------- Signed-off-by: Gabriel Fukushima <[email protected]> Signed-off-by: jflo <[email protected]> * fix log params (#6254) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: jflo <[email protected]> * add dependency on jar task (#6255) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * Fix and test that the BlockAwareOperationTracer methods are invoked the correct number of times (#6259) * Test that the BlockAwareOperationTracer are invoked the correct number of times * Remove redundant calls to traceEndBlock Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: jflo <[email protected]> * [RPC] Use apiConfiguration to limit gasPrice in eth_getGasPrice (#6243) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: jflo <[email protected]> * log bootnodes and static nodes list at debug level (#6273) * log bootnodes and static nodes list at debug level Signed-off-by: Sally MacFarlane <[email protected]> * log if zero bootnodes Signed-off-by: Sally MacFarlane <[email protected]> * null safeguards Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * junit 5 (#6256) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * Non bft group ats junit 5 (#6260) * migrate to junit 5 Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * Txparse subcommand implementation (#6268) * txparse subcommand Signed-off-by: garyschulte <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * [MINOR] migrate remaining Crypto tests to junit 5 (#6280) * update crypto tests to junit5 * fixed temp file * removed vintage junit dep Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: jflo <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (#6205) revert some modification that was made to pass tests #5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]> * Sequenced pool synonym for legacy pool (#6274) * Sequenced pool synonym for legacy pool Signed-off-by: Matthew Whitehead <[email protected]> * Class rename Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> * Add SEQUENCED to config overview test Signed-off-by: Matthew Whitehead <[email protected]> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (#6205) revert some modification that was made to pass tests #5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]> * ETC mainnet 'Spiral' activation block (#6267) * Set ENR tree for DNS discovery for ETC mainnet network Signed-off-by: Diego López León <[email protected]> * Set activation block number for ECIP-1109 on ETC mainnet Signed-off-by: Diego López León <[email protected]> --------- Signed-off-by: Diego López León <[email protected]> Signed-off-by: jflo <[email protected]> * uprev to version 23.10.3-RC3 Signed-off-by: jflo <[email protected]> --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: jflo <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: David Lutzardo <[email protected]> Signed-off-by: Gabriel Fukushima <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: delehef <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Franklin Delehelle <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: matkt <[email protected]> Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Diego López León <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Co-authored-by: David Lutzardo <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Gabriel Fukushima <[email protected]> Co-authored-by: delehef <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Matt Whitehead <[email protected]> Co-authored-by: Diego López León <[email protected]>
alexandratran
removed
the
doc-change-required
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
* Sequenced pool synonym for legacy pool Signed-off-by: Matthew Whitehead <[email protected]> * Class rename Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> * Add SEQUENCED to config overview test Signed-off-by: Matthew Whitehead <[email protected]> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (hyperledger#6205) revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]>
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
* Sequenced pool synonym for legacy pool Signed-off-by: Matthew Whitehead <[email protected]> * Class rename Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> * Add SEQUENCED to config overview test Signed-off-by: Matthew Whitehead <[email protected]> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (hyperledger#6205) revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Signed-off-by: Gabriel Fukushima <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 18, 2023
* Sequenced pool synonym for legacy pool Signed-off-by: Matthew Whitehead <[email protected]> * Class rename Signed-off-by: Matthew Whitehead <[email protected]> * Spotless fixes Signed-off-by: Matthew Whitehead <[email protected]> * Add SEQUENCED to config overview test Signed-off-by: Matthew Whitehead <[email protected]> * Update CHANGELOG.md Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * add a fix to load correctly the storage trie in the Bonsai WorldState (hyperledger#6205) revert some modification that was made to pass tests hyperledger#5686 and fix this tests by loading the storage with EMPTY_TRIE_HASH if we detect that it has been cleared before pushing the new slots after recreation. --------- Signed-off-by: Karim TAAM <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: matkt <[email protected]> Signed-off-by: jflo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Introduces the new
sequencedsynonym for thelegacytransaction pool, as discussed in #6211.The PR adds enough for users to start switching to the
--tx-pool=sequencedoption ahead of removal of thelegacypool in the future.I've added one or two additional unit tests to check that
legacyoptions still work with thesequencedpool, but haven't done anything more comprehensive than that because the future PR todeprecateremove thelegacypool will refactor all of the existing tests to usesequencedanyway.Fixed Issue(s)
Fixes #6211