chore: Simplify point decoding logic#267
Merged
garyschulte merged 4 commits intobesu-eth:mainfrom Apr 28, 2025
Merged
Conversation
Contributor
Author
|
Whether we want this depends on if we do the nested if condition in #262 With this change, we always do a isOnCurveCheck and optionally do a subgroup check (from the API perspective), whereas in 262, we do a IsOnCurveCheck and a subgroup check at once, then depending on the outcome we do a isOnCurveCheck to distinguish the error |
Contributor
|
LGTM, benchmarks appear essentially unchanged: |
garyschulte
force-pushed
the
kw/simplify-point-decode-logic
branch
from
30533fd to
6e68096
Compare
Contributor
|
this diff includes 262 (simplest method to get CI to run), and can be rebased once it merges |
macfarla
approved these changes
Apr 28, 2025
…g unless the combined subgroup check fails Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
garyschulte
force-pushed
the
kw/simplify-point-decode-logic
branch
from
6e68096 to
81eadb7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #264