chore: remove unused methods and move call to G1_MUL and G2_MUL to golang code#263
Merged
garyschulte merged 19 commits intobesu-eth:mainfrom Mar 19, 2025
Merged
Conversation
kevaundray
commented
Mar 18, 2025
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: kevaundray <kevtheappdev@gmail.com> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
force-pushed
the
kw/cleanup-extra-methods
branch
from
3e06b75 to
901fbb4
Compare
Signed-off-by: kevaundray <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
force-pushed
the
kw/cleanup-extra-methods
branch
from
2562dea to
ceeb419
Compare
garyschulte
requested changes
Mar 18, 2025
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
LGTM, some suggestions and nits
gnark/src/main/java/org/hyperledger/besu/nativelib/gnark/LibGnarkEIP2537.java
Outdated
Show resolved
Hide resolved
gnark/src/main/java/org/hyperledger/besu/nativelib/gnark/LibGnarkEIP2537.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
force-pushed
the
kw/cleanup-extra-methods
branch
from
5c5e0e7 to
a915bd7
Compare
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: kevaundray <kevtheappdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: