Merged
Conversation
Contributor
Author
|
@kevaundray for visibility |
kevaundray
reviewed
Mar 17, 2025
kevaundray
reviewed
Mar 17, 2025
kevaundray
reviewed
Mar 17, 2025
Contributor
Author
|
I will measure the difference in cost to do duplicated isOnCurve checks and post here |
…g unless the combined subgroup check fails Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/check-curve-only-once
branch
from
e7b57d4 to
e0630a8
Compare
Contributor
Author
|
circling back to this, keeping the duplicated isOnCurve check does not appear to incur a significant penalty. I will keep the explicit checks rather than relying on the implicit isOnCurve check being done in the latest gnark-crypto release. 👍 |
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/check-curve-only-once
branch
10 times, most recently
from
86dad06 to
930a7bf
Compare
…n compatibility with older glibc versions Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/check-curve-only-once
branch
from
930a7bf to
7b3aefa
Compare
macfarla
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.