-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vale guidelines checker and fix issues #570
Merged
NicolasMassart
merged 4 commits into
hyperledger:master
from
NicolasMassart:560-update-vale
Dec 14, 2020
Merged
Update Vale guidelines checker and fix issues #570
NicolasMassart
merged 4 commits into
hyperledger:master
from
NicolasMassart:560-update-vale
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas MASSART <[email protected]>
exclude vale style dirs from lint checks Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
bgravenorst
reviewed
Dec 14, 2020
bgravenorst
reviewed
Dec 14, 2020
bgravenorst
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion.
MadelineMurray
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments. Nice to see all those spelling errors fixed :-)
Signed-off-by: Nicolas MASSART <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before pushing any commit in your pull request, make sure that:
Describe the change
Issue fixed
fixes #560
Impacted parts
For content changes
For tools changes
Review process
You can probably skip looking at the changes in
CI/vale/vale_styles/Microsoft
,CI/vale/vale_styles/proselint
andCI/vale/vale_styles/write-good
as they are imported styles I did not change them only moved them or added some.Only the
CI/vale/vale_styles/Besu
andCI/vale/vale_styles/Vocab/Besu/accept.txt
have changes that you should check.Testing
Run
CI/scripts/test_all.sh