Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Limit Trie Logs Early Access Feature Guide #1538

Merged
merged 20 commits into from
Mar 19, 2024

Conversation

joaniekube
Copy link
Contributor

@joaniekube joaniekube commented Mar 12, 2024

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:06pm

@joaniekube joaniekube marked this pull request as ready for review March 12, 2024 18:15
@joaniekube joaniekube requested a review from a team as a code owner March 12, 2024 18:15
@non-fungible-nelson
Copy link
Contributor

LGTM - let's ship and re-evaluate in an upcoming release of Besu.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tweaks

Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more minor comments, but think it's close enough - thanks! 👍

joaniekube and others added 2 commits March 18, 2024 17:15
Signed-off-by: Joan E <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge after committing suggestions, since this is short-lived content. For future reference, also make sample commands more readable by adding line breaks (for example: https://besu.hyperledger.org/public-networks/tutorials/besu-teku-mainnet#beacon-node-only

Copy link
Contributor Author

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandratran is Mainnet always capitalized, or just in this case? Looking at instances of it, it seems that it is stylized as "mainnet" for general cases. Is it a proper noun in this, because we are referring to the Ethereum Mainnet?

Copy link
Contributor Author

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
@alexandratran
Copy link
Contributor

@joaniefromtheblock We use capital "Mainnet" whenever we refer to it throughout the Besu docs and most of our other docs. We can discuss updating this in the future, but for consistency we should stick to one style throughout the docs. Where do you see instances of lowercase "mainnet" in our docs?

@joaniekube joaniekube merged commit 1b43f77 into hyperledger:main Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants