Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document profile files #1514

Merged
merged 9 commits into from
Feb 17, 2024
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 15, 2024

Signed-off-by: Alexandra Tran <[email protected]>
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2024 6:05am

Alexandra Tran added 2 commits February 14, 2024 23:46
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Copy link
Contributor

@non-fungible-nelson non-fungible-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small nit, not a blocker

Signed-off-by: Alexandra Tran <[email protected]>
@bgravenorst
Copy link
Contributor

bgravenorst commented Feb 15, 2024

Do the various profiles affect the performance of the Besu node in any way? May be worth mentioning. Also, what problem is --profiles solving?

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment and a couple of questions.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"profile file" always sounds weird in my head but I can't think how you would reword it - other than just using "profile"

@macfarla
Copy link
Contributor

Do the various profiles affect the performance of the Besu node in any way? May be worth mentioning. Also, what problem is --profiles solving?

using a profile won't change performance (although the settings within the profile might do - that's kind of the point of them).

what problem are they solving? trying to make besu easier to "get started" with - there's a bit more context here https://wiki.hyperledger.org/display/BESU/Change+to+Besu+Defaults+-+Q1+2024

Alexandra Tran and others added 2 commits February 16, 2024 21:55
@alexandratran
Copy link
Contributor Author

"profile file" always sounds weird in my head but I can't think how you would reword it - other than just using "profile"

@macfarla I updated the wording to just "profile" and it sounds better.

@alexandratran alexandratran merged commit d47de7b into hyperledger:main Feb 17, 2024
9 checks passed
@alexandratran alexandratran deleted the 1512-profiles branch February 17, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for new --profile CLI option
4 participants