-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document profile files #1514
Document profile files #1514
Conversation
Signed-off-by: Alexandra Tran <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
docs/public-networks/how-to/use-configuration-file/profile-file.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - small nit, not a blocker
Signed-off-by: Alexandra Tran <[email protected]>
docs/public-networks/how-to/use-configuration-file/profile-file.md
Outdated
Show resolved
Hide resolved
Do the various profiles affect the performance of the Besu node in any way? May be worth mentioning. Also, what problem is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment and a couple of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"profile file" always sounds weird in my head but I can't think how you would reword it - other than just using "profile"
docs/public-networks/how-to/use-configuration-file/profile-file.md
Outdated
Show resolved
Hide resolved
using a profile won't change performance (although the settings within the profile might do - that's kind of the point of them). what problem are they solving? trying to make besu easier to "get started" with - there's a bit more context here https://wiki.hyperledger.org/display/BESU/Change+to+Besu+Defaults+-+Q1+2024 |
Signed-off-by: Alexandra Tran <[email protected]>
@macfarla I updated the wording to just "profile" and it sounds better. |
Document
--profile
CLI option and add how-to page on using profile files. Slight updates to the "Use a configuration file" page. Fixes #1512.Previews:
--profile
documentation: https://besu-docs-qvq914ru4-hyperledger.vercel.app/development/public-networks/reference/cli/options#profile