Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Joan as docs maintainer #1507

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add Joan as docs maintainer #1507

merged 3 commits into from
Feb 21, 2024

Conversation

alexandratran
Copy link
Contributor

This PR adds Joan Edwards (@joaniefromtheblock) to the list of Besu docs maintainers. She has authored the following PRs:

You can see her current list of PRs.

Note: This PR also moves Mike Sanko to emeritus status.

Add Joan as docs maintainer
4ac0389 
Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran alexandratran requested a review from a team as a code owner February 7, 2024 19:43
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 7:16pm

@joaniekube
Copy link
Contributor

Thanks @alexandratran! I accept this nomination and hope to be a long-term contributor. Thank you very much for the nomination

bgravenorst
bgravenorst approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jflo
jflo approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joan asks good questions and does good work.

gfukushima
gfukushima approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

macfarla
macfarla approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Joan!

reorder alphabetically
6165ee4 
Signed-off-by: Alexandra Tran <[email protected]>
jframe
jframe approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran
Copy link
Contributor Author

Merging this as it's been 2 weeks.

@alexandratran alexandratran merged commit 5b89e2b into hyperledger:main Feb 21, 2024
9 checks passed
@alexandratran alexandratran mentioned this pull request Feb 21, 2024
Closed
@alexandratran alexandratran deleted the add-joan-maintainer branch February 21, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

@jframe jframe jframe approved these changes

@macfarla macfarla macfarla approved these changes

@siladu siladu siladu approved these changes

@gfukushima gfukushima gfukushima approved these changes

@bgravenorst bgravenorst bgravenorst approved these changes

@fab-10 fab-10 fab-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@alexandratran @joaniekube @jflo @jframe @macfarla @siladu @gfukushima @bgravenorst @fab-10