Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txpool options #1339

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Txpool options #1339

merged 5 commits into from
Jun 6, 2023

Conversation

bgravenorst
Copy link
Contributor

@bgravenorst bgravenorst commented Jun 5, 2023

#568 # Pull request checklist

Document missing transaction pool CLI options.

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

After creating your PR and tests have finished

Make sure that:

Preview

https://hyperledger-besu--1339.org.readthedocs.build/en/1339/public-networks/reference/cli/options/#tx-pool-disable-locals

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst requested a review from a team as a code owner June 5, 2023 03:06
Signed-off-by: bgravenorst <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion on wording for the disable-locals option

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst requested a review from alexandratran June 5, 2023 04:46
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions.

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst merged commit 90c2176 into hyperledger:main Jun 6, 2023
@bgravenorst bgravenorst deleted the txpoolOptions branch June 6, 2023 01:25
joshuafernandes pushed a commit to Consensys/besu-docs that referenced this pull request Jun 21, 2023
* Add missing tx-pool options.

Signed-off-by: bgravenorst <[email protected]>

* Typos...

Signed-off-by: bgravenorst <[email protected]>

* Typos...

Signed-off-by: bgravenorst <[email protected]>

* Implement feedback.

Signed-off-by: bgravenorst <[email protected]>

* Address reviewer feedback.

Signed-off-by: bgravenorst <[email protected]>

---------

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>
alexandratran added a commit that referenced this pull request Jun 22, 2023
* fix: removing comments

Signed-off-by: Joshua Fernandes <[email protected]>

* fix: algolia -> local search

* homepage, footer, logo, categories, and images

Signed-off-by: Alexandra Tran <[email protected]>

* fix footer, swizzle version banner+badge and tags

Signed-off-by: Alexandra Tran <[email protected]>

* docs: add documentation tags

Signed-off-by: Byron Gravenorst <[email protected]>

* minor edit

Signed-off-by: Alexandra Tran <[email protected]>

* docs: update navigation bar

Signed-off-by: Byron Gravenorst <[email protected]>

* Remove Husky.

Signed-off-by: bgravenorst <[email protected]>

* docs: revert Husky removal

Signed-off-by: bgravenorst <[email protected]>

* remove husky, integrate latest changes, + edits

Signed-off-by: Alexandra Tran <[email protected]>

* update project-words.txt

Signed-off-by: Alexandra Tran <[email protected]>

* prettier format

Signed-off-by: Alexandra Tran <[email protected]>

* fixes

Signed-off-by: Alexandra Tran <[email protected]>

* js -> jsx

Signed-off-by: Alexandra Tran <[email protected]>

* clear jsx warnings

Signed-off-by: Alexandra Tran <[email protected]>

* release docs version 23.4.1

Signed-off-by: Alexandra Tran <[email protected]>

* update footer and version redirects

Signed-off-by: Alexandra Tran <[email protected]>

* fix: removing comments

Signed-off-by: Joshua Fernandes <[email protected]>

* fix: algolia -> local search

Signed-off-by: Joshua Fernandes <[email protected]>

* homepage, footer, logo, categories, and images

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* fix footer, swizzle version banner+badge and tags

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* docs: add documentation tags

Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* minor edit

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* docs: update navigation bar

Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* Remove Husky.

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* docs: revert Husky removal

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* remove husky, integrate latest changes, + edits

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* Update for OpenJ9 instructions. (#1334)

* Update for OpenJ9 instructions.

Signed-off-by: Matt Nelson <[email protected]>

* fix lint

Signed-off-by: Matt Nelson <[email protected]>

* more lint/spelling.

Signed-off-by: Matt Nelson <[email protected]>

* edit pr

Signed-off-by: Alexandra Tran <[email protected]>

---------

Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* First draft performance troubleshooting page (#1335)

* First draft performance troubleshooting page.

Signed-off-by: Matt Nelson <[email protected]>

* tweaks and linter

Signed-off-by: Matt Nelson <[email protected]>

* edit PR content

Signed-off-by: Alexandra Tran <[email protected]>

---------

Signed-off-by: Matt Nelson <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>

* Txpool options (#1339)

* Add missing tx-pool options.

Signed-off-by: bgravenorst <[email protected]>

* Typos...

Signed-off-by: bgravenorst <[email protected]>

* Typos...

Signed-off-by: bgravenorst <[email protected]>

* Implement feedback.

Signed-off-by: bgravenorst <[email protected]>

* Address reviewer feedback.

Signed-off-by: bgravenorst <[email protected]>

---------

Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* update project-words.txt

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* prettier format

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* fixes

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* js -> jsx

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* clear jsx warnings

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* release docs version 23.4.1

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* update footer and version redirects

Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Joshua Fernandes <[email protected]>

* use  yarn to build and not npm

Signed-off-by: Joshua Fernandes <[email protected]>

* updating versions and redirects

Signed-off-by: Joshua Fernandes <[email protected]>

* fix prettier?

Signed-off-by: Alexandra Tran <[email protected]>

---------

Signed-off-by: Joshua Fernandes <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: Matt Nelson <[email protected]>
Co-authored-by: Alexandra Tran <[email protected]>
Co-authored-by: bgravenorst <[email protected]>
Co-authored-by: Matt Nelson <[email protected]>
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants