Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflows #1147

Merged
merged 25 commits into from
Sep 14, 2022
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Aug 25, 2022

Pull request checklist

Use the following list to make sure your PR fits the Besu documentation quality standard.

Before creating the pull request

Make sure that:

Describe the change

Replacing Circle CI workflows by Github Workflows.

Why? It's constantly blocking contributors who are not part of HL because they can't see what's failing and we have to fix for them as they can't re-run. Plus we regularly have issues of Circle not running despite the webhook firing well. Have this integrated with Github action provides all the features plus the ease of use and flexibility.

Issue fixed

Circle CI not running tests and non HL contributors not being able to see what's failing.

fixes #1146

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example, lint or vale)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

https://hyperledger-besu--1147.org.readthedocs.build/en/1147/

Alexandra Tran added 2 commits August 25, 2022 09:31
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran alexandratran requested a review from a team as a code owner August 25, 2022 16:53
@alexandratran alexandratran marked this pull request as draft August 25, 2022 16:53
Signed-off-by: Nicolas MASSART <[email protected]>
@NicolasMassart NicolasMassart force-pushed the 1146-gh-actions branch 4 times, most recently from 75d6c29 to 2801433 Compare September 8, 2022 15:57
@NicolasMassart NicolasMassart self-assigned this Sep 8, 2022
@NicolasMassart NicolasMassart added the DocOps Related to documentation system, tools and CI label Sep 8, 2022
@NicolasMassart NicolasMassart force-pushed the 1146-gh-actions branch 2 times, most recently from 89d4bec to 2ad113d Compare September 9, 2022 11:29
Signed-off-by: Nicolas MASSART <[email protected]>
@NicolasMassart NicolasMassart force-pushed the 1146-gh-actions branch 2 times, most recently from 7b1c854 to d82f8e7 Compare September 9, 2022 13:31
Signed-off-by: Nicolas MASSART <[email protected]>
@NicolasMassart NicolasMassart force-pushed the 1146-gh-actions branch 3 times, most recently from 8cd2014 to 576ea18 Compare September 9, 2022 14:32
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
and move assets to exclude easily

Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>

# Conflicts:
#	docs/assets/images/Architecture.png
#	docs/index.md
#	docs/private-networks/tutorials/quickstart.md
Signed-off-by: Nicolas MASSART <[email protected]>
@NicolasMassart
Copy link
Contributor

NicolasMassart commented Sep 12, 2022

@alexandratran everything passes except the links (we have to wait for splunk to revive their server but otherwise we can override)
LGTM Python fails... well because I removed all python stuff so it has nothing to build but it's not mandatory check and it will eventually detect that there's no python in the project once merged.
All the Circle CI required steps are showing as not running, because they were removed (replaced by a dummy one to prevent the Circle CI webhook to break until we merge). But I'm keeping them required for now until we merge this PR as otherwise it will impact other PRs.

@NicolasMassart NicolasMassart marked this pull request as ready for review September 12, 2022 15:34
Signed-off-by: Nicolas MASSART <[email protected]>

# Conflicts:
#	CI/linkchecker/link_check_conf.json
#	docs/public-networks/how-to/monitor/understand-metrics.md
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Copy link
Contributor Author

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old architecture diagram was removed in #1158, so it doesn't need to be added back here. Otherwise, LGTM!

Signed-off-by: Nicolas MASSART <[email protected]>
@NicolasMassart NicolasMassart merged commit b9e467f into hyperledger:main Sep 14, 2022
@alexandratran alexandratran deleted the 1146-gh-actions branch September 14, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocOps Related to documentation system, tools and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Github Actions
2 participants