-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflows #1147
Add GitHub workflows #1147
Conversation
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Alexandra Tran <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
aa466cc
to
8c94880
Compare
Signed-off-by: Nicolas MASSART <[email protected]>
75d6c29
to
2801433
Compare
89d4bec
to
2ad113d
Compare
Signed-off-by: Nicolas MASSART <[email protected]>
7b1c854
to
d82f8e7
Compare
Signed-off-by: Nicolas MASSART <[email protected]>
8cd2014
to
576ea18
Compare
Signed-off-by: Nicolas MASSART <[email protected]>
576ea18
to
c5adee3
Compare
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
and move assets to exclude easily Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]> # Conflicts: # docs/assets/images/Architecture.png # docs/index.md # docs/private-networks/tutorials/quickstart.md
Signed-off-by: Nicolas MASSART <[email protected]>
@alexandratran everything passes except the links (we have to wait for splunk to revive their server but otherwise we can override) |
Signed-off-by: Nicolas MASSART <[email protected]> # Conflicts: # CI/linkchecker/link_check_conf.json # docs/public-networks/how-to/monitor/understand-metrics.md
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
Signed-off-by: Nicolas MASSART <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old architecture diagram was removed in #1158, so it doesn't need to be added back here. Otherwise, LGTM!
Signed-off-by: Nicolas MASSART <[email protected]>
Pull request checklist
Use the following list to make sure your PR fits the Besu documentation quality standard.
Before creating the pull request
Make sure that:
Describe the change
Replacing Circle CI workflows by Github Workflows.
Why? It's constantly blocking contributors who are not part of HL because they can't see what's failing and we have to fix for them as they can't re-run. Plus we regularly have issues of Circle not running despite the webhook firing well. Have this integrated with Github action provides all the features plus the ease of use and flexibility.
Issue fixed
Circle CI not running tests and non HL contributors not being able to see what's failing.
fixes #1146
Impacted parts
For content changes:
For tool changes:
After creating your PR and tests have finished
Make sure that:
and added a preview link.
Preview
https://hyperledger-besu--1147.org.readthedocs.build/en/1147/