Skip to content

Commit 0ae64f4

Browse files
committed
fix to use own event definition in tests
Signed-off-by: Jun Kimura <[email protected]>
1 parent 28b6c30 commit 0ae64f4

File tree

2 files changed

+58
-43
lines changed

2 files changed

+58
-43
lines changed

.gas-snapshot

+40-40
Original file line numberDiff line numberDiff line change
@@ -2,48 +2,48 @@ IBCTest:testBenchmarkCreateMockClient() (gas: 209341)
22
IBCTest:testBenchmarkLCUpdateMockClient() (gas: 39935)
33
IBCTest:testBenchmarkRecvPacket() (gas: 137264)
44
IBCTest:testBenchmarkSendPacket() (gas: 85111)
5-
IBCTest:testBenchmarkUpdateMockClient() (gas: 137315)
5+
IBCTest:testBenchmarkUpdateMockClient() (gas: 137380)
66
IBCTest:testToUint128((uint64,uint64)) (runs: 256, μ: 947, ~: 947)
7-
TestICS02:testCreateClient() (gas: 24730617)
8-
TestICS02:testInvalidCreateClient() (gas: 24578266)
9-
TestICS02:testInvalidUpdateClient() (gas: 24581452)
10-
TestICS02:testRegisterClient() (gas: 24325238)
11-
TestICS02:testRegisterClientDuplicatedClientType() (gas: 24307288)
12-
TestICS02:testRegisterClientInvalidClientType() (gas: 24292160)
13-
TestICS02:testUpdateClient() (gas: 24747541)
14-
TestICS03Handshake:testConnOpenAck() (gas: 1631286)
15-
TestICS03Handshake:testConnOpenConfirm() (gas: 1765699)
16-
TestICS03Handshake:testConnOpenInit() (gas: 1279049)
17-
TestICS03Handshake:testConnOpenTry() (gas: 2160427)
18-
TestICS03Handshake:testInvalidConnOpenAck() (gas: 1943429)
19-
TestICS03Handshake:testInvalidConnOpenConfirm() (gas: 2007619)
20-
TestICS03Handshake:testInvalidConnOpenInit() (gas: 666461)
21-
TestICS03Handshake:testInvalidConnOpenTry() (gas: 2073805)
22-
TestICS03Version:testCopyVersions() (gas: 558658)
23-
TestICS03Version:testFindSupportedVersion() (gas: 19400)
24-
TestICS03Version:testIsSupportedVersion() (gas: 7864)
25-
TestICS03Version:testPickVersion() (gas: 25399)
26-
TestICS03Version:testVerifyProposedVersion() (gas: 11777)
27-
TestICS03Version:testVerifySupportedFeature() (gas: 4153)
7+
TestICS02:testCreateClient() (gas: 24828609)
8+
TestICS02:testInvalidCreateClient() (gas: 24676246)
9+
TestICS02:testInvalidUpdateClient() (gas: 24679444)
10+
TestICS02:testRegisterClient() (gas: 24423230)
11+
TestICS02:testRegisterClientDuplicatedClientType() (gas: 24405280)
12+
TestICS02:testRegisterClientInvalidClientType() (gas: 24390152)
13+
TestICS02:testUpdateClient() (gas: 24845663)
14+
TestICS03Handshake:testConnOpenAck() (gas: 1636277)
15+
TestICS03Handshake:testConnOpenConfirm() (gas: 1772310)
16+
TestICS03Handshake:testConnOpenInit() (gas: 1281190)
17+
TestICS03Handshake:testConnOpenTry() (gas: 2166092)
18+
TestICS03Handshake:testInvalidConnOpenAck() (gas: 1951642)
19+
TestICS03Handshake:testInvalidConnOpenConfirm() (gas: 2017044)
20+
TestICS03Handshake:testInvalidConnOpenInit() (gas: 666722)
21+
TestICS03Handshake:testInvalidConnOpenTry() (gas: 2079624)
22+
TestICS03Version:testCopyVersions() (gas: 560134)
23+
TestICS03Version:testFindSupportedVersion() (gas: 19740)
24+
TestICS03Version:testIsSupportedVersion() (gas: 8272)
25+
TestICS03Version:testPickVersion() (gas: 26823)
26+
TestICS03Version:testVerifyProposedVersion() (gas: 12185)
27+
TestICS03Version:testVerifySupportedFeature() (gas: 4357)
2828
TestICS04Handshake:testBindPort() (gas: 40333)
29-
TestICS04Handshake:testChanClose() (gas: 8475602)
30-
TestICS04Handshake:testChanOpenAck() (gas: 2882165)
31-
TestICS04Handshake:testChanOpenConfirm() (gas: 3062397)
32-
TestICS04Handshake:testChanOpenInit() (gas: 2197364)
33-
TestICS04Handshake:testChanOpenTry() (gas: 2655756)
34-
TestICS04Handshake:testInvalidChanOpenAck() (gas: 2059642)
35-
TestICS04Handshake:testInvalidChanOpenConfirm() (gas: 2117621)
36-
TestICS04Handshake:testInvalidChanOpenInit() (gas: 1272924)
37-
TestICS04Handshake:testInvalidChanOpenTry() (gas: 1348072)
38-
TestICS04Packet:testAcknowledgementPacket() (gas: 2283020)
39-
TestICS04Packet:testInvalidSendPacket() (gas: 2294517)
40-
TestICS04Packet:testRecvPacket() (gas: 7604920)
41-
TestICS04Packet:testRecvPacketTimeoutHeight() (gas: 2320237)
42-
TestICS04Packet:testRecvPacketTimeoutTimestamp() (gas: 2318872)
43-
TestICS04Packet:testSendPacket() (gas: 5093797)
44-
TestICS04Packet:testTimeoutOnClose() (gas: 2507647)
45-
TestICS20:testAddressToHex(address) (runs: 256, μ: 22713, ~: 22824)
29+
TestICS04Handshake:testChanClose() (gas: 8493283)
30+
TestICS04Handshake:testChanOpenAck() (gas: 2886058)
31+
TestICS04Handshake:testChanOpenConfirm() (gas: 3067098)
32+
TestICS04Handshake:testChanOpenInit() (gas: 2199573)
33+
TestICS04Handshake:testChanOpenTry() (gas: 2658841)
34+
TestICS04Handshake:testInvalidChanOpenAck() (gas: 2062335)
35+
TestICS04Handshake:testInvalidChanOpenConfirm() (gas: 2120446)
36+
TestICS04Handshake:testInvalidChanOpenInit() (gas: 1275021)
37+
TestICS04Handshake:testInvalidChanOpenTry() (gas: 1350509)
38+
TestICS04Packet:testAcknowledgementPacket() (gas: 2286474)
39+
TestICS04Packet:testInvalidSendPacket() (gas: 2297971)
40+
TestICS04Packet:testRecvPacket() (gas: 7973268)
41+
TestICS04Packet:testRecvPacketTimeoutHeight() (gas: 2323693)
42+
TestICS04Packet:testRecvPacketTimeoutTimestamp() (gas: 2322328)
43+
TestICS04Packet:testSendPacket() (gas: 5793531)
44+
TestICS04Packet:testTimeoutOnClose() (gas: 2512437)
45+
TestICS20:testAddressToHex(address) (runs: 256, μ: 22698, ~: 22824)
4646
TestICS20:testHexToAddress(string) (runs: 256, μ: 4776, ~: 4734)
4747
TestICS20:testIsEscapedString() (gas: 48979)
4848
TestICS20:testMarshaling() (gas: 148145)
49-
TestICS20:testParseAmount(uint256) (runs: 256, μ: 27316, ~: 23633)
49+
TestICS20:testParseAmount(uint256) (runs: 256, μ: 27053, ~: 22172)

tests/foundry/src/helpers/ICS04PacketTestHelper.t.sol

+18-3
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,21 @@ abstract contract ICS04PacketEventTestHelper {
251251
bytes acknowledgement;
252252
}
253253

254+
event SendPacket(
255+
uint64 sequence,
256+
string sourcePort,
257+
string sourceChannel,
258+
Height.Data timeoutHeight,
259+
uint64 timeoutTimestamp,
260+
bytes data
261+
);
262+
263+
event WriteAcknowledgement(
264+
string destinationPortId, string destinationChannel, uint64 sequence, bytes acknowledgement
265+
);
266+
267+
event RecvPacket(Packet.Data packet);
268+
254269
function getLastSentPacket(IIBCHandler handler, Vm.Log[] memory logs) internal view returns (Packet.Data memory) {
255270
for (uint256 i = logs.length; i > 0; i--) {
256271
if (logs[i - 1].emitter == address(handler)) {
@@ -319,7 +334,7 @@ abstract contract ICS04PacketEventTestHelper {
319334
}
320335

321336
function tryDecodeSendPacketEvent(Vm.Log memory log) internal pure returns (Packet.Data memory p, bool) {
322-
if (log.topics[0] != IICS04SendPacket.SendPacket.selector) {
337+
if (log.topics[0] != SendPacket.selector) {
323338
return (p, false);
324339
}
325340
return (decodeSendPacketEvent(log.data), true);
@@ -351,7 +366,7 @@ abstract contract ICS04PacketEventTestHelper {
351366
pure
352367
returns (WriteAcknolwedgement memory wa, bool)
353368
{
354-
if (log.topics[0] != IICS04WriteAcknowledgement.WriteAcknowledgement.selector) {
369+
if (log.topics[0] != WriteAcknowledgement.selector) {
355370
return (wa, false);
356371
}
357372
return (decodeWriteAcknowledgementEvent(log.data), true);
@@ -368,7 +383,7 @@ abstract contract ICS04PacketEventTestHelper {
368383
}
369384

370385
function tryDecodeRecvPacketEvent(Vm.Log memory log) internal pure returns (Packet.Data memory p, bool) {
371-
if (log.topics[0] != IIBCChannelRecvPacket.RecvPacket.selector) {
386+
if (log.topics[0] != RecvPacket.selector) {
372387
return (p, false);
373388
}
374389
return (decodeRecvPacketEvent(log.data), true);

0 commit comments

Comments
 (0)