Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Consider adding configuration parameters for actor channels #3364

Closed
Erigara opened this issue Apr 11, 2023 · 1 comment
Closed
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Erigara
Copy link
Contributor

Erigara commented Apr 11, 2023

          These (actor channel capacities) should be config params at some point. 
          
          Consider adding them (with defaults) to the `p2p` config proxy. 

Originally posted by @appetrosyan in #3346 (comment)

Currently all bounded channels of iroha have capacity of 1, without observed performance penalties. Additional benefit of smallest possible capacity is that we will find out about any communication problems sooner than later.
We should discus and consider addition of configuration params to change capacity of actor channels.

@Erigara Erigara added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 11, 2023
@appetrosyan appetrosyan changed the title [feature]: Consider add configuration parameters for actor channels [feature]: Consider adding configuration parameters for actor channels Apr 11, 2023
@mversic
Copy link
Contributor

mversic commented Oct 19, 2023

not relevant anymore

@mversic mversic closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

2 participants