feat(consortium-manual): add prometheus exporter #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagpreetsinghsasan
requested review from
jonathan-m-hamilton and
petermetz
as code owners
petermetz
requested changes
Mar 19, 2021
jagpreetsinghsasan
force-pushed
the
feature-538
branch
from
bf55f94 to
dd3a0fe
Compare
petermetz
approved these changes
Mar 22, 2021
takeutak
approved these changes
Mar 23, 2021
|
@AzaharaC @jordigiam Could you take a look at this1 test failure? I know this PR is unrelated, but that test failure looks like a randomly occurring flake in the nonce handling2 probably due to race conditions (just a guess). |
Primary Change -------------- 1. The consortium-manual plugin now includes the prometheus metrics exporter integration 2. OpenAPI spec now has api endpoint for the getting the prometheus metrics Refactorings that were also necessary to accomodate 1) and 2) ------------------------------------------------------------ 3. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint 4. IPluginConsortiumManualOptions interface in PluginConsortiumManual class now has a prometheusExporter optional field 5. The PluginConsortiumManual class has relevant functions and codes to incorporate prometheus exporter 6. get-node-jws-endpoint-v1.test.ts is changed to incorporate the prometheus exporter 7. Added Readme.md on the prometheus exporter usage Fixes hyperledger-cacti#538 Signed-off-by: Jagpreet Singh Sasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(consortium-manual): add prometheus exporter
Resolve #538
Signed-off-by: Jagpreet Singh Sasan [email protected]