fix(cmd-api-server): missing pretsc npm script #500 #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `pretsc` script that generates the Typescript client files based on the openapi.json specs. Also updated the openapi.json so that the healthcheck endpoint has a shortened operation ID (which is a separate, larger effort that is still pending across the entire code-base so figured it's good to start addressing it piece by piece at least while we are at it). Also added the axios dependency to the cmd-api-server package since this is necessary for the exported Typescript API client object to work properly (it is being used for sending the HTTP requests) Fixes hyperledger-cacti#500 Signed-off-by: Peter Somogyvari <[email protected]> (cherry picked from commit 2b7f1cc0adbab31382443d44072ef4e01f73cb88) Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added
bug
takeutak
approved these changes
Jan 19, 2021
petermetz
deleted the
fix/cmd-api-server/missing-pretsc-npm-script-500
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
pretscscript that generates the Typescriptclient files based on the openapi.json specs.
Also updated the openapi.json so that the healthcheck
endpoint has a shortened operation ID (which is a
separate, larger effort that is still pending across
the entire code-base so figured it's good to start
addressing it piece by piece at least while we are
at it).
Also added the axios dependency to the cmd-api-server
package since this is necessary for the exported
Typescript API client object to work properly
(it is being used for sending the HTTP requests)
Fixes #500
Signed-off-by: Peter Somogyvari [email protected]
(cherry picked from commit 2b7f1cc0adbab31382443d44072ef4e01f73cb88)
Signed-off-by: Peter Somogyvari [email protected]