Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sawtooth-ledger): add single sawtooth test ledger image #2110

Merged
merged 1 commit into from
Aug 25, 2022
Merged

feat(sawtooth-ledger): add single sawtooth test ledger image #2110

merged 1 commit into from
Aug 25, 2022

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jul 1, 2022

feat(sawtooth-ledger): add single sawtooth test ledger image

  • Enclose starting sawtooth ledger into single container that will fetch and run the entire setup.
  • Remove reduntant files, update the readme.
  • Add SawtoothTestLedger class to simplify setting the test ledger in jest tests.
  • Refactor electricity-trade to generate usage without sawtooth shell patching.
  • Refactor electricity-trade to use new sawtooth ledger container and wait until it's healthy.

Closes: #2108

Depends on: #2030

Signed-off-by: Michal Bajer [email protected]

outSH added a commit to outSH/cactus that referenced this pull request Jul 1, 2022
@outSH
test(connector-sawtooth-socketio): add functional test, bug fix
f02e13f 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this pull request Jul 1, 2022
Merged
jagpreetsinghsasan
jagpreetsinghsasan approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

izuru0
izuru0 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

petermetz
petermetz requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH

  1. FYI: The official image is now published here: https://github.com/orgs/hyperledger/packages/container/package/cactus-sawtooth-all-in-one
  2. Could you please also add the publis CI yaml file in the .github/workflows dir next to the rest of the container publishing files? Easiest is to just copy paste one of the existing ones and then you mostly just tell it where the dockerfile is and how to build it (please be sure to use a docker build command in that yaml file that works from the project root directory without having to change directories inwards first.

packages/cactus-test-tooling/src/main/typescript/sawtooth/sawtooth-test-ledger.ts Outdated Show resolved Hide resolved
packages/cactus-test-tooling/src/main/typescript/sawtooth/sawtooth-test-ledger.ts Outdated Show resolved Hide resolved
@outSH outSH force-pushed the sawtooth_ledger_refactor_pr branch 2 times, most recently from 3c36618 to 835b3c2 Compare August 10, 2022 08:21
@outSH
Copy link
Contributor Author

outSH commented Aug 10, 2022 •
edited
Loading

@petermetz

1. FYI: The official image is now published here: https://github.com/orgs/hyperledger/packages/container/package/cactus-sawtooth-all-in-one

Thanks!

2. Could you please also add the publis CI yaml file in the .github/workflows dir next to the rest of the container publishing files? Easiest is to just copy paste one of the existing ones and then you mostly just tell it where the dockerfile is and how to build it (please be sure to use a docker build command in that yaml file that works from the project root directory without having to change directories inwards first.

Oh, forgot about that, thanks for reminder - done :)

@outSH outSH requested a review from petermetz August 10, 2022 08:27
petermetz
petermetz approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, forgot about that, thanks for reminder - done :)

@outSH My pleasure, thank you for making the updates! LGTM!

@outSH @petermetz
feat(sawtooth-ledger): add single sawtooth test ledger image
d072a23 
- Enclose starting sawtooth ledger into single container that will fetch and run the entire setup.
- Remove reduntant files, update the readme.
- Add SawtoothTestLedger class to simplify setting the test ledger in jest tests.
- Refactor electricity-trade to generate usage without sawtooth shell patching.
- Refactor electricity-trade to use new sawtooth ledger container and wait until it's healthy.

Closes: hyperledger-cacti#2108

Depends on: hyperledger-cacti#2030

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the sawtooth_ledger_refactor_pr branch from 835b3c2 to d072a23 Compare August 25, 2022 16:44
@petermetz petermetz merged commit cd4c746 into hyperledger-cacti:main Aug 25, 2022
outSH added a commit to outSH/cactus that referenced this pull request Nov 21, 2022
@outSH
test(connector-sawtooth-socketio): add functional test, bug fix
5387569 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this pull request Nov 22, 2022
@outSH @petermetz
test(connector-sawtooth-socketio): add functional test, bug fix
8f1ee01 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this pull request Nov 22, 2022
@outSH @petermetz
test(connector-sawtooth-socketio): add functional test, bug fix
0491747 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this pull request Nov 23, 2022
@outSH @petermetz
test(connector-sawtooth-socketio): add functional test, bug fix
246a971 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: hyperledger-cacti#2107

Depends on: hyperledger-cacti#2109
Depends on: hyperledger-cacti#2110
Depends on: hyperledger-cacti#2047

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this pull request Nov 24, 2022
@outSH @petermetz
test(connector-sawtooth-socketio): add functional test, bug fix
8867830 
- Add functional test of all functions from sawtooth-socketio validator.
- Refactor sawtooth validator to allow importing as a module, to simplify the functional test.
- Add stopMonitor to terminate tests easily.
- Allow multiple clients to monitor for blocks.
- Fix parsing of URL from config so that it doesn't depend on trailing slash anymore.

Closes: #2107

Depends on: #2109
Depends on: #2110
Depends on: #2047

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izuru0 izuru0 izuru0 approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@petermetz petermetz petermetz approved these changes

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(sawtooth-ledger): add single sawtooth test ledger image
4 participants
@outSH @petermetz @jagpreetsinghsasan @izuru0