feat(quorum-connector): implement validator interface on go-quorum-connector

[outSH]

• Add three new endpoints to quorum ledger connector achieve legacy verifier compatibility.
  • InvokeRawWeb3EthContractEndpoint can be used to form any call to deployed contract.
  • InvokeRawWeb3EthMethodEndpoint can be used to call any web3.eth function. Both are marked as low-level functions, should be used only when there's no designated endpoint for given functionality yet.
  • WatchBlocksV1Endpoint can be used to monitor new block headers / data from the ledger. Type of the output is determined from input option flag.
• Extend QuorumApiClient to support Verifier interface, that is: block monitoring, and sending sync/async requests. Sending requests is marked as deprecated, because user can use direct REST calls from generated ApiClient, nevertheless this API was requested by one of the teams.
• Added functional tests for two new, request based endpoints.
• Moved verifier-besu integration test to besu-test package.
• Added verifier-quorum integration test, it supplements direct endpoint tests and provides a reference for API usage.
• Added support for QuorumApiClient in Verifier.

Closes: #1604
Signed-off-by: Michal Bajer [email protected]

Notes

• I can't make CodeQL to cooperate, it reports dynamic call errors, even though I explicitly check if methods are defined on a contract / object (also assert they type is a function). Tried different methods to make the scanner notice it but did not succeed. Please double check and mark as false positive if possible.

Depends on #1928
Depends on #1926

[outSH]

@petermetz @izuru0 @takeutak Please review (only the last commit)

[outSH]

I've updated quorum ledger plugin readme as requested by @izuru0:

• Added section on QuorumApiClient shortly describing it's capabilities.
• Updated running container commands.

Running containers doesn't work though because of missing run-time-error package. I've added it to package.json, can't test it because of reasons described in #1897.

I've also changed dockerfile to use upstream ghcr.io/hyperledger/cactus-cmd-api-server:v1.0.0 instead of local cactus-api-server:latest

[izuru0]

LGTM

[outSH]

@petermetz Thanks for the detailed review, appreciate it :) I've added fixes in a separate commit for easier review fix: fixing code review issues, will squash it once the PR is ready to merge.

[petermetz]

@petermetz Thanks for the detailed review, appreciate it :) I've added fixes in a separate commit for easier review fix: fixing code review issues, will squash it once the PR is ready to merge.

@outSH My pleasure and thank you for the separate commits, that does make it easier! It's LGTM now so please squash+rebase prior merging.
If you need any help with addressing CodeQL errors just let me know we can work together to figure it out.

[petermetz]

@outSH LGTM

[outSH]

@petermetz Thanks! :)

As for CodeQL, I've wrote an explanation in notes already that I don't think I can solve them :( I've seen on my branch that similar issue already occurs here and in some other modules, so I assume it was ignored there. The problem is most probably false positive at this point, since all execution paths are checked (please review the affected functions in the connector to be sure)

[github-actions]

This PR/issue depends on:

• refactor(quorum-multi-party-all-in-one): enhance quorum-mp image #1928
• fix(api-server): allow no authorization on socketio endpoints #1926
  By Dependent Issues (🤖). Happy coding!

[outSH]

@petermetz OK, I've rebased and cleared the commit history. Can you review the CodeQL related message I wrote earlier and merge if possible?

[petermetz]

@outSH LGTM, thank you!