Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-besu): invokeContractV2 replacement transaction underpriced #747

Closed
petermetz opened this issue Mar 30, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@petermetz
Copy link
Contributor

petermetz commented Mar 30, 2021

Describe the bug

https://github.com/hyperledger/cactus/pull/684/checks?check_run_id=2223081488#step:15:950

I know this PR is unrelated, but that test failure looks like a randomly occurring flake in the nonce handling2 probably due to race conditions (just a guess).
What I confirmed so far is that the test works on my machine, but it failed while being executed by the CI (usually the CI is good at catching race conditions because it's slow.

To Reproduce

It appears to be flaky or only happen on weaker hardware under heavy load, not sure.

Expected behavior

Test should pass consistently.

Logs/Stack traces

https://github.com/hyperledger/cactus/pull/684/checks?check_run_id=2223081488#step:15:950

Screenshots

N/A

Cloud provider or hardware configuration:

CI

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

main

Hyperledger Cactus Plugins/Connectors Used

Besu. I suspect that Quorum may also be affected, but who knows.

Additional context

This came up randomly after rebasing Jagpreet's prometheus PR to upstream/main. I'm assuming that the monitoring code does not have any side effects on the rest of the connector logic, but this could also turn out to be false of course.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan

@petermetz
Copy link
Contributor Author

Never seen the flake again so closing this one. Will open a follow-up task to design a nonce manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant