-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-registry): get keychain by keychainId #381
Labels
enhancement
New feature or request
Milestone
Comments
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Nov 10, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
This was referenced Nov 10, 2020
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Nov 12, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Dec 1, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Dec 11, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Dec 11, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Dec 14, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes hyperledger-cacti#381 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this issue
Dec 15, 2020
Adds a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found. Fixes #381 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently when I want to locate a keychain plugin based on the keychain ID I have to type out the filtering logic myself and handle the sad path of the plugin not being in the registry as well.
Describe the solution you'd like
I want a utility method where I can just pass in the keychain ID and get back a plugin instance or an exception thrown if it was not found.
Describe alternatives you've considered
Considered having this utility method outside of the
PluginRegistry
class itself, but the method itself is definitely needed to reduce boilerplate code.cc: @takeutak @sfuji822 @jonathan-m-hamilton
The text was updated successfully, but these errors were encountered: