-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server - Add a config to define what files should be treated as JSON Schema files #5
Comments
Can I work on this one @jdesrosiers |
My partner and I would like to work on this issue. Please assign. I have created a DM group on slack with my partner to discuss and collaborate as mentioned in the qualification task requirements. Thanks. @jdesrosiers |
hey! @jdesrosiers please assign this to me i'll be working with @Adity20 |
Hello @jdesrosiers
|
We'll have to work on issue #4 to get more out of these changes. |
A few things sound a bit off.
This sounds too focused on directories. I expect something like a list of patterns that files need to match. For example, the default is
I don't think you actually have to implement the logic for identifying the files. That functionality is built in. You should just need to pass in a new set of patterns. That's my expectation at least, but I could be wrong.
I'm not sure I see a need for error handling. If a pattern includes a directory that doesn't exist, then nothing will match that pattern.
Another group is working on #4 as part of their task. You'll need to coordinate with them. |
Firstly thanks for clarifying each point with such details @jdesrosiers |
The server is hardcoded to identify
**/*.schema.json
and**/schema.json
files as JSON Schema files. This setting would allow you to change that. For example, users should be able to select a directory where the client will look for schemas.Depends on: #4
The text was updated successfully, but these errors were encountered: