Skip to content

Comments

Expose Extensions::into_http and Status::from_error#1067

Merged
LucioFranco merged 1 commit intohyperium:masterfrom
jdahlq:tonic-pub2
Aug 24, 2022
Merged

Expose Extensions::into_http and Status::from_error#1067
LucioFranco merged 1 commit intohyperium:masterfrom
jdahlq:tonic-pub2

Conversation

@jdahlq
Copy link
Contributor

@jdahlq jdahlq commented Aug 24, 2022

Expose Extensions::into_http and Status::from_error as public.

Motivation

See #910. These functions must be public in order to implement async_interceptor in its own external crate.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucioFranco LucioFranco merged commit 2a83f8b into hyperium:master Aug 24, 2022
@jdahlq
Copy link
Contributor Author

jdahlq commented Aug 24, 2022

Thanks! Could we publish a new version with this change so that I can publish my async_interceptor crate? Sorry to bug you about this, just trying to close the loop here :)

@sgarciac
Copy link

(@jdahlq: I'm waiting for your crate to be published :D)

@LucioFranco
Copy link
Member

@jdahlq I can get a release out next week there are a couple more PRs I wanna get merged for that, if thats okay.

@jdahlq
Copy link
Contributor Author

jdahlq commented Aug 26, 2022

@LucioFranco Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants