Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Make generated server service public #347

Merged
merged 1 commit into from
May 8, 2020
Merged

fix(build): Make generated server service public #347

merged 1 commit into from
May 8, 2020

Conversation

l4l
Copy link
Contributor

@l4l l4l commented May 7, 2020

resolves #344

LucioFranco
LucioFranco approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco changed the title Unhide doc for generated service fix(build): Make generated server service public May 8, 2020
@LucioFranco LucioFranco merged commit 8cd6f05 into hyperium:master May 8, 2020
@l4l l4l deleted the unhide-doc-service branch May 8, 2020 14:34
@Michael-F-Bryan
Copy link

Thanks for fixing this @l4l. Do you know when the next release will be coming out?

@LucioFranco
Copy link
Member

@Michael-F-Bryan I can get one out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why doc(hidden) on impl Service?
3 participants
@l4l @Michael-F-Bryan @LucioFranco