Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tonic server process exit unexpected when the client get a wrong tls config #1897

Closed
zier-one opened this issue Aug 28, 2024 · 3 comments

Comments

@zier-one
Copy link

zier-one commented Aug 28, 2024

Bug Report

Version

v0.12.2 and master branch

Platform

Darwin XXX 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000 arm64

Description

First, let's try to run the server.rs and client.rs in examples/src/tls.
The server says:

Got a request from Some([::1]:59511) with info TlsConnectInfo { inner: TcpConnectInfo { local_addr: Some([::1]:50051), remote_addr: Some([::1]:59511) }, certs: None }

And the client says:

RESPONSE=Response { metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 28 Aug 2024 09:15:40 GMT", "grpc-status": "0"} }, message: EchoResponse { message: "hello" }, extensions: Extensions }

Everything is OK for now.

Then, let's change one line in client.rs:

let tls = ClientTlsConfig::new()
.ca_certificate(ca)
.domain_name("example.com");

modify .domain_name("example.com"); to .domain_name("wrong.com"); in L16

And then, run the server.rs and client.rs again.

We can see the client says:

Error: tonic::transport::Error(Transport, ConnectError(Custom { kind: InvalidData, error: InvalidCertificate(NotValidForName) }))

It's OK, but the server process EXIT WITH NO ERROR. It confuses me.

@zier-one zier-one changed the title The tonic server exit unexpected when the client get a wrong tls config The tonic server process exit unexpected when the client get a wrong tls config Aug 28, 2024
@zier-one
Copy link
Author

I've located the bug is caused by this pr c3be20c

@zier-one
Copy link
Author

And I try to fix it in #1885 (comment)

@zier-one
Copy link
Author

fixed in #1885

This was referenced Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants