Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MAX_CONNECTION_AGE and MAX_CONNECTION_AGE_GRACE equivalents #1428

Closed
jalaziz opened this issue Jul 11, 2023 · 2 comments
Closed

Comments

@jalaziz
Copy link

jalaziz commented Jul 11, 2023

Feature Request

Motivation

In order to properly support DNS-based client side gRPC load balancing, the server must periodically terminate the client connection gracefully by sending a GOWAY frame and subsequently closing the connection.

MAX_CONNECTION_AGE and MAX_CONNECTION_AGE_GRACE are defined in the gRPC Server-side connection management.

Unfortunately, due the inconsistent support of client connection timeout settings in gRPC client libraries, the current recommendation appears to be to use service side.

These issues provide more context:

Proposal

Introduce max_connection_age and max_connection_age_grace server timeouts. On first look, it appears support would need to be added to hyper first.

Alternatives

The alternative is client side timeouts. Unfortunately, client side timeouts are not implemented consistently. See grpc/grpc-go#1663.

I am not aware of any alternatives other than service meshes, proxies, xDS, or a custom gRPC resolver or load balancing mechanism (all of which can be quite complex).

@ionut-slaveanu
Copy link
Contributor

I created a pull request here:
#1865

@jalaziz
Copy link
Author

jalaziz commented Oct 29, 2024

Closing this now that #1865 has been merged.

@jalaziz jalaziz closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants