fix: rustup

[fhartwig]

• enable slice_patterns feature
• add Reflect trait bounds where necessary

[GitCop]

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

• Commit: 6a80399
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

---

This message was auto-generated by https://gitcop.com

[fhartwig]

Amended commit message to make gitcop happy.

[seanmonstar]

Thanks! I wonder, if slice_patterns aren't going to be stable for beta/1.0,
we should probably not use them. I think they're only used in the
authorization header, and shouldn't be too hard to switch it to a few if
clauses.

On Sun, Mar 29, 2015, 9:18 AM Florian Hartwig [email protected]
wrote:

Amended commit message to make gitcop happy.

—
Reply to this email directly or view it on GitHub
#404 (comment).

[fhartwig]

rust-lang/rust#23121 says that they hope to have it ready for the beta release, but I'm not sure if that still applies. I can re-write the function to avoid slice patterns if you like.

[seanmonstar]

With beta this week, those comments don't assure me. If you could remove
the patterns, awesome. Or I can a little later.

On Sun, Mar 29, 2015, 9:57 AM Florian Hartwig [email protected]
wrote:

rust-lang/rust#23121 rust-lang/rust#23121
says that they hope to have it ready for the beta release, but I'm not sure
if that still applies. I can re-write the function to avoid slice patterns
if you like.

—
Reply to this email directly or view it on GitHub
#404 (comment).

[fhartwig]

Ok, slice patterns are gone. Tests pass for me, travis seems to have trouble with github today.

[reem]

Reflect shouldn't be needed in this file as far as I can tell. What error comes up if you remove these bounds?

[reem]

I see, since our Header traits should require Reflect.

[fhartwig]

error: the trait `core::marker::Reflect` is not implemented for the type `S` [E0277]

(in lines 26 and 47)

[reem]

The Header downcasting stuff all needs Reflect bounds similar to Any and NetworkStream to be safe.

[Ryman]

According to this the bound should be Any rather than Reflect + 'static as Any implies that?

[reem]

@Ryman you're right. The existing Any bound should be sufficient.