Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] about "request header size limit" (Server Side) #3832

Open
myyrakle opened this issue Jan 16, 2025 · 0 comments
Open

[Feature Request] about "request header size limit" (Server Side) #3832

myyrakle opened this issue Jan 16, 2025 · 0 comments
Labels
C-feature Category: feature. This is adding a new feature.

Comments

@myyrakle
Copy link

myyrakle commented Jan 16, 2025

Is your feature request related to a problem? Please describe.
I need "the ability to limit the size of Request Header".
Although it is possible to implement this in an application, I think it is most efficient if it can be handled at the protocol implementation level.

Describe the solution you'd like
Currently, it is supported to specify the number of headers through the "h1_max_headers" option when creating a builder. I think it would be okay to control it by adding a few properties like this.

Describe alternatives you've considered
If we implement the header max setting, there may be several ways to do this.

  1. number of header: already implemented
  2. max size of each heade name: Fixed at 64kb
  3. max size of each heade value: none (maybe)
  4. max size of total header: none

What if all of this could be set as a builder option? What do you think about this?

Question
If the problem was simple, I would implement it myself and post a PR, but a question arose while looking at the code.
Image
There is evidence of an attempt to add an option called "h1_max_header_size". What exactly is the max that this is trying to implement?

@myyrakle myyrakle added the C-feature Category: feature. This is adding a new feature. label Jan 16, 2025
@myyrakle myyrakle changed the title [Feature Request] about "request header size limit" [Feature Request] about "request header size limit" (Server Side) Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature. This is adding a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant