Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore_invalid_headers option for HTTP/1 server requests #3825

Closed
seanmonstar opened this issue Jan 9, 2025 · 1 comment · Fixed by #3824
Closed

Add ignore_invalid_headers option for HTTP/1 server requests #3825

seanmonstar opened this issue Jan 9, 2025 · 1 comment · Fixed by #3824
Labels
A-http1 Area: HTTP/1 specific. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

This proposes adding an option to hyper::server::conn::http1::Builder: ignore_invalid_headers(bool).

This could make use of the related option in httparse: https://docs.rs/httparse/latest/httparse/struct.ParserConfig.html#method.ignore_invalid_headers_in_requests
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. A-http1 Area: HTTP/1 specific. labels Jan 9, 2025
@GlenDC GlenDC mentioned this issue Jan 9, 2025
Merged
@GlenDC
Copy link
Contributor

GlenDC commented Jan 9, 2025

Resolved in #3824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http1 Area: HTTP/1 specific. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http1 expose ignore_invalid_headers_in_requests opt GlenDC/hyper
2 participants
@seanmonstar @GlenDC