Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The script that generates the header file is not available #3708

Closed
spongehah opened this issue Jul 17, 2024 · 2 comments · Fixed by #3800
Closed

The script that generates the header file is not available #3708

spongehah opened this issue Jul 17, 2024 · 2 comments · Fixed by #3800
Labels
A-ffi Area: ffi (C API) C-chore Category: chore. a general chore or maintenance task. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@spongehah
Copy link

When I delete the header file under capi/include, run the command:

(base) spongehah@MacBook capi % ./gen_header.sh
cp: /Users/spongehah/Document/src/hyper/capi/include/hyper.h: No such file or directory
rm: /Users/spongehah/Document/src/hyper/capi/include/hyper.h.backup: No such file or directory
@spongehah spongehah added the C-bug Category: bug. Something is wrong. This is bad! label Jul 17, 2024
@seanmonstar
Copy link
Member

Why are you deleting the file first?


As I look through the script again, I see it creates a backup to be able to diff them, if you passed --verify (which is what we used in CI). I suppose the script could be modified to only create a backup if --verify was passed.

@spongehah
Copy link
Author

Why are you deleting the file first?

As I look through the script again, I see it creates a backup to be able to diff them, if you passed --verify (which is what we used in CI). I suppose the script could be modified to only create a backup if --verify was passed.

I just want to verify that the script works

@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-ffi Area: ffi (C API) C-chore Category: chore. a general chore or maintenance task. and removed C-bug Category: bug. Something is wrong. This is bad! labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ffi Area: ffi (C API) C-chore Category: chore. a general chore or maintenance task. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants