-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse AbsolutePath further #298
Comments
Would it not be better if the |
Could do that. But a Url struct would add 6 fields that wouldn't be used: scheme, username, password, host, port, and default port. And I'm not sure if hyper would always know its hostname in every circumstance. Also, the Url::parse_path() output seems to be geared for this usage, only there is no struct, it just returns a 3-tuple. Could take that approach too (i.e. drop the struct). |
Maybe having accessors on the
|
Sounds good. |
See https://github.com/mikedilger/hyper/tree/parse_absolute_path for a possible way forward.
That branch offers several benefits, but also has a few problems:
Benefits:
Problems:
The text was updated successfully, but these errors were encountered: