-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Trailers support in C API #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah, sure. We do have support for trailers on the a streaming body, but currently it only supports HTTP/2 trailers (there hasn't been much demand for HTTP/1.1 trailers). So there's two steps here:
|
I would also like to see support added for sending trailers in HTTP chunked requests. |
Good point, I don't know why I say "client-side receiving" and "server-side sending". I've cleaned them up to just "receiving" and "sending". |
Let's me have a try. |
The following curl tests fail due to hyper's lack of trailers support: 266, 1417, 1540, 1591, 1943. |
FWIW, I haven't seen much demand for HTTP/1.1 trailers from anything else. So priority of implementing this (at least myself) is pretty low. Would it work to just mark all those as known to not work? |
In curl it is already documented as a feature that does not work with hyper. We have set of those. That list is unfortunate because it confuses users and we will need to make sure to distribute the knowledge of those limitations into the user documentation if they remain when we want to remove the experimental tag. |
I'm making curl use hyper instead of its native HTTP code.
curl supports trailers but I find no API to get them provided from hyper so until it does, I can't make curl+hyper match the native implementation in features.
Sample HTTP/1.1 response below. I want the
chunky-trailer: header data
part.The text was updated successfully, but these errors were encountered: