Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel blocking DNS lookup if GaiFuture dropped #2686

Closed
seanmonstar opened this issue Nov 5, 2021 · 4 comments
Closed

Cancel blocking DNS lookup if GaiFuture dropped #2686

seanmonstar opened this issue Nov 5, 2021 · 4 comments
Labels
A-client Area: client. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

The GaiFuture owns a Tokio JoinHandle, spawning a call to getaddrinfo in a blocking thread. If a request times out before the blocking thread started the call, we should have it removed from the queue. That can be done with impl Drop for GaiFuture that calls JoinHandle::abort().
@seanmonstar seanmonstar added A-client Area: client. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Nov 5, 2021
@ahmedsobeh
Copy link
Contributor

Hi! Looking to get into the code-base and contributing to it, so I will give this a shot as a start!

@ahmedsobeh
Copy link
Contributor

Would it be possible to add me to the repo to open a pull request? Thanks in advance

@sfackler
Copy link
Contributor

sfackler commented Nov 8, 2021

You shouldn't need any special permissions to open a pull request. You will need to make a fork of the repo and push your changes to that, though.

@ahmedsobeh
Copy link
Contributor

Ah yeah, all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanmonstar @sfackler @ahmedsobeh