Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch fails to build with --all-targets #1863

Closed
matthiaskrgr opened this issue Jul 12, 2019 · 2 comments · Fixed by #1865
Closed

master branch fails to build with --all-targets #1863

matthiaskrgr opened this issue Jul 12, 2019 · 2 comments · Fixed by #1865

Comments

@matthiaskrgr
Copy link

cargo check  --all-targets

    Checking hyper v0.13.0-a.0 (/tmp/hyper)
error[E0463]: can't find crate for `futures`
 --> tests/client.rs:4:1
  |
4 | extern crate futures;
  | ^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: Could not compile `hyper`.
warning: build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `tokio_mockstream`
   --> src/common/io/rewind.rs:128:5
    |
128 |     extern crate tokio_mockstream;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: Could not compile `hyper`.
warning: build failed, waiting for other jobs to finish...
error[E0425]: cannot find function `run` in module `rt`
  --> examples/proxy.rs:43:9
   |
43 |     rt::run(server);
   |         ^^^ not found in `rt`

error: unused import: `Future`
 --> examples/proxy.rs:7:23
  |
7 | use hyper::rt::{self, Future};
  |                       ^^^^^^
  |
note: lint level defined here
 --> examples/proxy.rs:1:9
  |
1 | #![deny(warnings)]
  |         ^^^^^^^^
  = note: #[deny(unused_imports)] implied by #[deny(warnings)]

error[E0277]: the trait bound `[closure@examples/proxy.rs:21:23: 34:6 client_main:_, out_addr_clone:_]: hyper::service::MakeService<&'a hyper::server::conn::AddrStream>` is not satisfied
  --> examples/proxy.rs:37:10
   |
37 |         .serve(new_service)
   |          ^^^^^ the trait `hyper::service::MakeService<&'a hyper::server::conn::AddrStream>` is not implemented for `[closure@examples/proxy.rs:21:23: 34:6 client_main:_, out_addr_clone:_]`
   |
   = note: required because of the requirements on the impl of `hyper::service::MakeServiceRef<hyper::server::conn::AddrStream>` for `[closure@examples/proxy.rs:21:23: 34:6 client_main:_, out_addr_clone:_]`

error[E0599]: no method named `map_err` found for type `hyper::Server<hyper::server::conn::AddrIncoming, [closure@examples/proxy.rs:21:23: 34:6 client_main:_, out_addr_clone:_]>` in the current scope
  --> examples/proxy.rs:38:10
   |
38 |         .map_err(|e| eprintln!("server error: {}", e));
   |          ^^^^^^^

error: aborting due to 4 previous errors

Some errors have detailed explanations: E0277, E0425, E0599.
For more information about an error, try `rustc --explain E0277`.
error: Could not compile `hyper`.

To learn more, run the command again with --verbose.

This broke clippy CI rust-lang/rust-clippy#4270

@seanmonstar
Copy link
Member

Ah, I didn't realize others were testing hyper master for things. As part of #1836, master disabled running its tests in CI since they aren't updated yet.

I've seen the pattern of moving disabled things to a tests_disabled directory in other projects, I think doing that here would fix this?

@seanmonstar seanmonstar changed the title fails to build with --all-targets master branch fails to build with --all-targets Jul 12, 2019
@seanmonstar
Copy link
Member

Ok, I've manually disabled tests/examples that aren't working, and added cargo build --all-targets to CI to be sure :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants