Default sleep_on_errors to false

[sanmai-NL]

The behavior in https://docs.rs/hyper/0.12.14/hyper/server/conn/struct.AddrIncoming.html#method.set_sleep_on_errors (PR #1450) is speculative. It shouldn’t default to true, since it masks error conditions and does not appreciably reduce the risk of service unavailability, as intended (#1358).

I suggest to default this parameter to false or, better yet, remove this code.

[sanmai-NL]

Although the implementer notes an error log entry would be emitted, he/she does not indicate how to control and view this error log. E.g., what env. var. should be set and for which path?

[sanmai-NL]

I invite @klausi (issue reporter and main implementer) and @aep (discussion contributor) to this discussion.

[seanmonstar]

Sleeping on TCP accept errors is actually common in other libraries, like nginx, nodejs, Netty...

Was it masking an actual problem in your server?

[sanmai-NL]

@seanmonstar Perhaps yes.

Could you please point me to the code and the rationale for this behavior in nginx or Netty? nginx isn’t a library AFAIK so the error handling strategy would be different.

[seanmonstar]

• nginx: https://github.com/nginx/nginx/blob/1028d71/src/event/ngx_event_accept.c#L99-L127
• Netty: netty/netty@dcf7896