Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptors(PWM): fix wrong duty cycle after kill program #994

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 19, 2023

Solved issues and/or description of the change

After a program with PWM usage is stopped by e.g. STRG-C, a restart is sometimes not possible due to bad state of duty cycle value. This can be solved by automatically adjusting the duty cycle on program start. This feature still exist, but was not enabled before.

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): tinkerboard

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review October 19, 2023 16:07
@gen2thomas gen2thomas merged commit 124499d into hybridgroup:dev Oct 19, 2023
2 checks passed
@gen2thomas gen2thomas deleted the fix/pwm_after_kill branch October 19, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant